Tagged Questions

4
votes
4answers
204 views

Command line Contact Management

Can you please review the following code and give any suggestions for improvment? Class ContactList.java import java.io.*; import java.util.*; public class ContactList { public static void ...
4
votes
1answer
137 views

Hangman: Is this small Haskell game clean and idiomatic Haskell code?

I hope this question isn't too general. I've been learning Haskell, and a while ago I created this Hangman game. I've been working on using a library for terminal output, so no more hardcoded escape ...
5
votes
1answer
104 views

Please review following code

Please review the following code. Methods getFirsts and getSeconds return a list of objects which implement CommonInterface and both of them are private. Is it a good or bad design. @Override public ...
7
votes
2answers
320 views

ViewModel constructor with many parameters

I have some ViewModels that have a lot of parameters like this one: public class ProductsMainViewModel : NotificationObject, IActiveAware, ... { public ProductsMainViewModel(IProductRepository ...
1
vote
1answer
125 views

How Can I improve This Level Parser?

The code for the LevelParser is shown below. It is also documented using Java-doc, the docs are in the project directory. Now by improving this piece of code, I do not mean optimizing it to ...
3
votes
2answers
113 views

Should I design my enumeration in some way that indicates what the highest value is?

This is a subtle question about design in which I want to find the most elegant and appropriate solution. I have an enumeration representing a French card deck (see code below). With it I need to do ...