PHP Parse error: syntax error, unexpected T_VARIABLE, expecting ',' or ';'

Question

i've been trying to get this script to load but every fix results in another error, am I missing something?

<?php
/************************************************************/
/*** A Script To Import / Export Tables as CSV Files ***/
/*** R. A. Davies 2009 ***/
/************************************************************/
/* Store name of this script */
$thisfile=substr(strrchr($_SERVER['PHP_SELF'], ‘/’), 1 );
/* If some action has been performed */
if (isset($_POST['action'])) {
/* Fetch Database Connection Settings */
$user=$_POST['dbusername'];
$host=$_POST['dbaddress'];
$pass=$_POST['dbpassword'];
$db=$_POST['dbname'];
/* Connect To Database */
$link = mysql_connect($host, $user, $pass) or die("Can not connect." . mysql_error());
mysql_select_db($db) or die("Can not connect.");
if ($_POST['action'] == 1) {
/* Fetch List of Tables From Database To Browse */
$sql = "SHOW TABLES FROM $db";
$result = mysql_query($sql);
if (!$result) {
echo ("DB Error, could not list tables");
echo ("MySQL Error: " . mysql_error());
exit;
}
/* If the user is not viewing or exporting a table, they just want a list of them */
if ((!isset($_POST['exporttable'])) && (!isset($_POST['viewtable']))) {
echo "<h1>Listing All Tables in $db</h1><table border=1>";
while ($row = mysql_fetch_row($result)) {
/* Print Out One Table At a Time, Give User Option To View Table Or Export */
echo "<tr><td>Table:</td><td><strong>{$row[0]}</strong></td><td>
<form action="$thisfile" method="post">
<input type="hidden" name="action" value="1">
<input type="hidden" name="viewtable" value="$row[0]">
<input type="hidden" name="dbname" value=".$_POST['dbname']."/>
<input type="hidden" name="dbaddress" value=".$_POST['dbaddress']."/>
<input type="hidden" name="dbusername" value=".$_POST['dbusername']."/>
<input type="hidden" name="dbpassword" value=".$_POST['dbpassword']." />
<input type="submit" value="view table">
</form></td><td>
<form action="$thisfile" method="post">
<input type="hidden" name="action" value="1?>
<input type="hidden" name="exporttable" value="$row[0]">
<input type="hidden" name="dbname" value=".$_POST['dbname']."/>
<input type="hidden" name="dbaddress" value=".$_POST['dbaddress']."/>
<input type="hidden" name="dbusername" value=".$_POST['dbusername']."/>
<input type="hidden" name="dbpassword" value=".$_POST['dbpassword']." />
<input type="submit" value="export table">
</form></td></tr>"; }
echo "</table>";
mysql_free_result($result);
}
/* If User Has Chosen To Export Table … */
if (isset($_POST['exporttable'])) {
$table=$_POST['exporttable'];
$link = mysql_connect($host, $user, $pass) or die("Can not connect." . mysql_error());
mysql_select_db($db) or die("Can not connect.");
/* List All Fields in Chosen Table */
$result = mysql_query("SHOW COLUMNS FROM ".$table."");
/* Fetch The Attributes of Each Field In Table */
$i = 0;
if (mysql_num_rows($result) > 0) {
while ($row = mysql_fetch_assoc($result)) {
$csv_output .= $row['Field']."; ";
$i++;
}
}
$csv_output .= "n";
/* Select All Fields Within Table and Print Them */
$values = mysql_query("SELECT * FROM ".$table."");
while ($rowr = mysql_fetch_row($values)) {
for ($j=0;$j<$i;$j++) {
$csv_output .= $rowr[$j]."; ";
}
$csv_output .= "n";
}
/* Start of Header To Send To Client */
$filename = $file."_".date("Y-m-d_H-i",time());
header("Content-type: application/vnd.ms-excel");
header("Content-disposition: csv" . date("Y-m-d") . ".csv");
header( "Content-disposition: filename=".$filename.".csv");
/* Send Output As File */
print $csv_output;
/* Ensure Script Terminates */
exit;
}
/* If The User Has Chosen To View A Table */
if (isset($_POST['viewtable'])) {
$table=$_POST['viewtable']; // name of table user has chosen to view
/* Fetch All Attributes About All Tables */
$result = mysql_query("SELECT * FROM $table");
$fields = mysql_num_fields($result);
$rows = mysql_num_rows($result);
$table = mysql_field_table($result, 0);
for ($i=0; $i < $fields; $i++) {
$type[$i] = mysql_field_type($result, $i);
$name[$i] = mysql_field_name($result, $i);
$len[$i] = mysql_field_len($result, $i);
$flags[$i] = mysql_field_flags($result, $i);
}
/* Now List All Fields */
$sql = "SHOW FIELDS FROM $table";
$result = mysql_query($sql);
if (!$result) {
echo "DB Error, could not list tablesn";
echo ‘MySQL Error: ‘ . mysql_error();
exit;
}
/* Output Headers Of Table */
echo "<table border=1><tr bgcolor="black"><td style="color:white"><strong>Fields in
<u>$table</u></strong></td><td style="color:white">Field Type</td>
<td style="color:white">Size</td><td style="color:white">Length</td>
<td style="color:white">Flags</td></tr>";
/* Output Fields One By One, Including The Attributes Fetched (Above) */
$x=0;
while ($row = mysql_fetch_row($result)) {
echo "<tr><td>{$row[0]}</td><td>";
echo $type[$x]."</td><td>";
echo $len[$x]."</td><td>";
echo $flags[$x++]."</td></tr>";
}
echo "</table><form action="$thisfile" method="post">
<input type="hidden" name="action" value="1?>
<input type="hidden" name="dbname" value=".$_POST ['dbname']."/>
<input type="hidden" name="dbaddress" value=".$_POST ['dbaddress']."/>
<input type="hidden" name="dbusername" value=".$_POST['dbusername']."/>
<input type="hidden" name="dbpassword" value=".$_POST ['dbpassword']." />
<input type="submit" value="Back" />
</form>
";
mysql_free_result($result);
}
}
else { /* Else they are not exporting, but IMPORTING */
/* Fetch Database Settings Again */
$databasehost = $_POST['dbaddress'];
$databasename = $_POST['dbname'];
$databasetable = $_POST['importtablename'];
$databaseusername =$_POST['dbusername'];
$databasepassword = $_POST['dbpassword'];
$fieldseparator = ",";
$lineseparator = "n";
/* Would you like to add an ampty field at the beginning of these records?
/* This is useful if you have a table with the first field being an auto_increment
integer
/* and the csv file does not have such as empty field before the records.
/* Set 1 for yes and 0 for no. ATTENTION: don’t set to 1 if you are not sure.
/* This can dump data in the wrong fields if this extra field does not exist in the
table
/********************************/
$addauto = 1;
/* Fetch CSV Content From File Uploaded By User */
$csvcontent = file_get_contents($_FILES['uploadedfile']['tmp_name']);
/* Connect To Database In Usual Way… */
$con = @mysql_connect($databasehost,$databaseusername,$databasepassword) or die (mysql_error());
@mysql_select_db($databasename) or die(mysql_error());
$lines = 0;
$queries = "";
$linearray = array();
/* Go through lines of CSV File One By One */
foreach(split($lineseparator,$csvcontent) as $line) {
$lines++;
$line = trim($line," t");
$line = str_replace("r","",$line);
$line = str_replace("‘","‘",$line);
$linearray = explode($fieldseparator,$line);
$linemysql = implode("‘,’",$linearray);
if($addauto)
$query = "insert into $databasetable values(",’$linemysql’);";
else
$query = "insert into $databasetable values(’$linemysql’);";
$queries .= $query . "n";
@mysql_query($query);
echo "executing : $query<br>";
}
@mysql_close($con);
echo "Found a total of $lines records in this csv file.n";
}
}
?>
<html>
<head>
<title>CSV File Importer / Exporter</title>
<style type="text/css">
body { padding:25px; text-align:center; /* for IE */
margin:0 auto; /* for the rest */ }
#import { float:left; margin-left:100px; }
#export { float:right; }
</style>
</head>
<h1>CSV PHP Importer/Exporter <a href="http://www.rogerdavies.com">Roger A. Davies</a>
&copy; 2009</h1>
<div id="export">
<h2>Export Database to CSV File</h2>
<p>Please enter your database settings to view database:</p>
<form action="<?=$thisfile;?>" method="post">
<input type="hidden" name="action" value="1?>
Database Name: <input type="text" name="dbname" value="<?=$_POST['dbname'];?>"/><br/>
Database Address: <input type="text" name="dbaddress" value="<?=$_POST ['dbaddress'];?>"/><br />
Database Username: <input type="text" name="dbusername" value="<?=$_POST ['dbusername'];?>" /><br />
Database Password: <input type="text" name="dbpassword" value="<?=$_POST ['dbpassword'];?>" /><br />
<input type="submit" value="Connect" />
</form>
</div>
<div id="import">
<h2>Import CSV File to Database</h2>
<form action="<?=$thisfile;?>"enctype="multipart/form-data" method="post">
<input type="hidden" name="action" value="2?>
Import To Table: <input type="text" name="importtablename" value="<?=$_POST ['importtablename'];?>"><br />
Choose a file to upload: <input name="uploadedfile" type="file" /><br />
Database Name: <input type="text" name="dbname" value="<?=$_POST['dbname'];?>"/><br/>
Database Address: <input type="text" name="dbaddress" value="<?=$_POST ['dbaddress'];?>"/><br />
Database Username: <input type="text" name="dbusername" value="<?=$_POST ['dbusername'];?>" /><br />
Database Password: <input type="text" name="dbpassword" value="<?=$_POST ['dbpassword'];?>" /><br />
<input type="submit" value="Import">
</form>
</div>
</html>

You're missing the line number that PHP reports the error at. I can't say that the thought of plowing through all that looking for the error thrills me.
... Do you really expect us to muck through all that code when you can simply just tell us what line the error appears on?

BoltClock · Answer 1 · 2010-11-23 07:07:37Z

The biggest mistake I see as I glance through your code for 5 seconds is that you are using unescaped double quotes to delimit your HTML attributes, which are interfering with the double-quoted PHP strings. Those would be the main culprits behind the onslaught of parse errors.

An example taken from one of your chunks of code:

echo "<tr><td>Table:</td><td><strong>{$row[0]}</strong></td><td>
<form action="$thisfile" method="post">
<input type="hidden" name="action" value="1">
<input type="hidden" name="viewtable" value="$row[0]">
...

A quick fix would be to change the attribute double quotes to single quotes:

echo "<tr><td>Table:</td><td><strong>{$row[0]}</strong></td><td>
<form action='$thisfile' method='post'>
<input type='hidden' name='action' value='1'>
<input type='hidden' name='viewtable' value='$row[0]'>
...

But remember, HTML can live outside of PHP tags, so I suggest you not use PHP to echo HTML as much as you can and use PHP tags wherever you need to echo PHP variables. That's called templating, and is one of the things PHP is designed for. Something like this (don't forget to use htmlspecialchars() to escape output):

<tr><td>Table:</td><td><strong><?php echo htmlspecialchars($row[0]); ?></strong></td><td>
<form action="<?php echo htmlspecialchars($thisfile); ?>" method="post">
<input type="hidden" name="action" value="1">
<input type="hidden" name="viewtable" value="<?php echo htmlspecialchars($row[0]); ?>">
...

Dan Grossman · Answer 2 · 2010-11-23 07:00:27Z

This whole thing where you echo a bunch of HTML:

echo "<tr><td>Table:</td><td><strong>{$row[0]}</strong></td><td>
<form action="$thisfile" method="post">
...

You have double quotes within the double quoted string. You can't do that. Either escape all the quotes with backslashes, or uses heredoc syntax:

http://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc

Quentin · Answer 3 · 2010-11-23 07:02:45Z

echo "<tr><td>Table:</td><td><strong>{$row[0]}</strong></td><td>
<form action="$thisfile" method="post">

The " immediately after echo starts a string. The " immediately after action= terminates it. Then you have an error.

(And that's why I avoid echoing large amounts of HTML. Use a template language. (PHP is one, so I'd make use of that and keep the HTML outside <?php ?>).

asked	1 year ago
viewed	1,166 times
active	1 year ago

PHP Parse error: syntax error, unexpected T_VARIABLE, expecting ',' or ';'

3 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged php html or ask your own question.

Hello World!

PHP Parse error: syntax error, unexpected T_VARIABLE, expecting ',' or ';'

3 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged php html or ask your own question.

Hello World!

Related