Question

0

If I am defining a function in JavaScript at the top of my page that validates if the string entered in a form is (A-Z,a-z, or 0-9). And then I call that function when they submit it saying :

onsubmit="return Validator(this);"

If the function name is :

function Validator(form)

Why isn't it actually validating the string submitted when we actually click on submit, and is there a better way of validating forms?

flag	asked Dec 2 at 19:30 unknown (google) 29●3 80% accept rate

	FYI, this doesn't have anything to do with PHP. – Tom Ritter Dec 2 at 19:35
	Check out this link yuilibrary.com/gallery/show/formvalidator Its a contribution to YUI, examples are here murdog05.github.com/yui3-gallery/… I think you'll find it useful. – Zoidberg Dec 2 at 19:38
	Please post some of the body of Validator. Otherwise how can we tell what the problem is:) – Byron Whitlock Dec 2 at 19:38

Byron Whitlock · Accepted Answer · 2009-12-03 19:33:52Z

0

You aren't submitting a string to Validator, you are submitting an input element. So you would do if(form.element.value != "") ... or something... And yes there is a better way

edited 2 days ago

answered Dec 2 at 19:35

Byron Whitlock
7,390●4●17

	No, input elements don't have submit events. It has to be a form. – David Dorward 2 days ago
	Absolutely right. Brainfart ;) – Byron Whitlock 2 days ago

David Dorward · Answer 2 · 2009-12-02 19:33:53Z

Almost certainly because the Validator function is not written correctly… but since you haven't shown us what it looks like, we can't say specifically why.

Perhaps it is expecting a String and you are giving it an HTMLFormElement.

Zoidberg · Answer 3 · 2009-12-02 19:40:37Z

Lots of options for form validation. Depending on your framework, you may want to use Jquery's validation. If you go with yui, I have submitted a form validator that will be useful

Here is the gallery submission, from thee you can look at examples

micahwittman · Answer 4 · 2009-12-03 04:01:40Z

An onsubmit handler function needs to return false to cancel the event (form submission) if you want to not submit and show a validation error message instead.

Plain Javascript approaches:
http://stackoverflow.com/questions/967483/form-is-still-submitted-even-though-listener-function-returns-false

jQuery approaches:
http://stackoverflow.com/questions/665470/how-to-not-submit-a-form-if-validation-is-false

Validating forms in HTML, PHP, and JavaScript

4 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged php javascript html or ask your own question.

Hello World!

Related