How can I run an if statement on a PHP GET variable using JavaScript?

Question

I found a nice little script on snippr(http://snipplr.com/view.php?codeview&id=799) that gives me the GET variables in an associative array.

// Read a page's GET URL variables and return them as an associative array.
function getUrlVars()
{
    var vars = [], hash;
    var hashes = window.location.href.slice(window.location.href.indexOf('?') + 1).split('&');

    for(var i = 0; i < hashes.length; i++)
    {
        hash = hashes[i].split('=');
        vars.push(hash[0]);
        vars[hash[0]] = hash[1];
    }

    return vars;
}

var get = getUrlVars();

I am trying to check to see if a certain GET variable is set and if the value is 'search'. For some reason my code is not catching the If statement and alerting even if the condition is not met.

if((get['search_housing']) = 'search') {
  alert('this works');
}

I'm not sure why it's not respecting my If statement. Is there something wrong with my code?

Tip: Look for a proper query string parser that performs URL-decoding. Perhaps: gist.github.com/143101 — Ateş Göral
– Ateş Göral, Commented Jan 29, 2012 at 7:04

Blender · Accepted Answer · 2012-01-29 06:14:03Z

5

The = operator sets the value.

You're looking for ==, which compares values:

if((get['search_housing']) == 'search') {
  alert('this works');
}

answered Jan 29, 2012 at 6:14

Blender

300k55 gold badges460 silver badges510 bronze badges

Add a comment |

Borealid · Accepted Answer · 2012-01-29 06:14:28Z

0

if((get['search_housing']) == 'search') {

DOUBLE equals!

answered Jan 29, 2012 at 6:14

Borealid

99.1k9 gold badges111 silver badges123 bronze badges

Add a comment |

summea · Accepted Answer · 2012-01-29 06:15:09Z

0

Maybe it needs to be this:

if((get['search_housing']) == 'search') {
    alert('this works');
}

See, the = would mean you are trying to assign 'search' to the get[].

answered Jan 29, 2012 at 6:15

summea

7,6434 gold badges35 silver badges49 bronze badges

Add a comment |

donutdan4114 · Accepted Answer · 2012-01-29 06:16:46Z

0

if(get('search_housing')==='search'){
  alert('test');
}

answered Jan 29, 2012 at 6:16

donutdan4114

1,2721 gold badge8 silver badges16 bronze badges

Add a comment |

mrtsherman · Accepted Answer · 2012-01-29 17:05:17Z

0

Try gup instead. That code you found doesn't look very robust. You probably want to unescape the returned value because you are comparing the results.

if (gup('search_housing') == 'search') { ... }

function gup( name )
{
  name = name.replace(/[\[]/,"\\\[").replace(/[\]]/,"\\\]");
  var regexS = "[\\?&]"+name+"=([^&#]*)";
  var regex = new RegExp( regexS );
  var results = regex.exec( window.location.href );
  if( results == null )
    return "";
  else
    return results[1];
}

edited Jan 29, 2012 at 17:05

answered Jan 29, 2012 at 6:15

mrtsherman

39.9k23 gold badges89 silver badges111 bronze badges

No query string parser is robust without URL-decoding.

Ateş Göral
– Ateş Göral

01/29/2012 07:03:50
Commented Jan 29, 2012 at 7:03
@AtesGoral - made a note about unescaping, although personally I always do this outside the value retrieval because I want the encoded value.

mrtsherman
– mrtsherman

01/29/2012 17:07:14
Commented Jan 29, 2012 at 17:07
I can see fringe cases where you might want to do that, but in general, not handling unescaping in your parser is a violation of layers.

Ateş Göral
– Ateş Göral

01/29/2012 19:03:32
Commented Jan 29, 2012 at 19:03

Add a comment |

Collectives™ on Stack Overflow

How can I run an if statement on a PHP GET variable using JavaScript?

5 Answers 5

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Your Answer

Sign up or log in

Post as a guest

Related