This tag is for questions about the practice of code review and code walkthroughs.
-1
votes
0answers
88 views
How to measure code quality? [closed]
Is there a methodology or any objective standard to determine whether the code of the project is well-written? How to measure in a structural and scientific manner to access the quality of the code?
...
40
votes
14answers
2k views
How important is positive feedback in code reviews?
Is it important to point out the good parts of the code during a code review and the reasons why it is good? Positive feedback might be just as useful for the developer being reviewed and for the ...
3
votes
4answers
259 views
Reusable VS clean code - where's the balance?
Let's say I have a data model for a blog posts and have two use-cases of that model - getting all blogposts and getting only blogposts which were written by specific author.
There are basically two ...
17
votes
3answers
616 views
Is a code review which uses only code comments a good idea?
Preconditions
Team uses DVCS
IDE supports comments parsing (like TODO and etc.)
Tools like CodeCollaborator are expensive for budget
Tools like gerrit are too complex for install or not usable
...
0
votes
2answers
151 views
Revamp application [closed]
I am a software developer having an experience of 3 yrs. I want to play with latest technologies always. But this is not practical. Because say, I developed a web application in .Net 3.5, now its 30% ...
42
votes
16answers
3k views
Review before or after code commit, which is better?
Traditionally we performed code review before commit, I had an argument with my colleague today, who preferred code review after commit.
First, here's some background,
We have some experienced ...
12
votes
4answers
740 views
Why don't interviewers ask the applicant to read some code?
I had a dozen interviews in my life (I'm about to graduate) and I wonder why I was only once asked to read and explain some code. Roughly, 90% jobs are mostly about maintaining existing systems. IMO ...
1
vote
2answers
276 views
Is it good/safe OOP practice to have a method whose only purpose is to send/retrieve data from another class?
I have a class that performs basic MySQL operations. This is all in PHP.
class dbTables {
public $name;
protected $fields = array(); // array of dbTableField objects
public $result_sets = ...
2
votes
2answers
175 views
How to document and peer review design in scrum?
I am a relatively new developer in a small business (a team of 3 developers and an equally small QA branch) working on a medium-sized system. The current iteration is still under 100k lines of code ...
5
votes
7answers
519 views
How to avoid typo errors, etc?
For the first time I have been coding for an open-source software where all my work gets reviewed before being commited. I understand reviewing work isn't an easy task, so I don't like to waste ...
2
votes
2answers
133 views
Why does the code auditing tools like FindBugs require a compile step to work properly?
Basically I ran Intellij Idea 's plug in called FindBugs-Idea to analyze my code . I corrected whatever errror was caught and then ran the tool again but it was still complaining about the same error ...
4
votes
7answers
356 views
How to get developers to do code reviews in a timely manner
The company I work for requires all code to be reviewed by other developers before it is committed. The members of my team are often frustrated because the other developers are too busy coding to do ...
2
votes
2answers
355 views
Can testers peer review the developers' design and code?
I am a junior developer for a small business using scrum / agile development. A long-term goal of ours is to be appraised at CMMI lvl 2. We have a team of 3 senior developers who implement user ...
8
votes
10answers
665 views
An environment where every SQL statement has to be reviewed by a DBA — is this common?
I mean everything, not just schema changes. Even a simple SELECT on a primary key can't go into production, even though it has been code-reviewed by other developers (in context), without a DBA review ...
31
votes
11answers
2k views
Is code reviewing good practice?
When the company I work in hired new managers, they offered us to overview someone's code on every meeting. We have meetings every two weeks, so each time one of developers was to show his/her code on ...
