Refactoring is a disciplined technique for restructuring an existing body of code, altering its internal structure without changing its external behavior.
4
votes
3answers
177 views
Using the mouse as a multi-tool creates heavy conditional logic for executing commands, how do I change this?
The feature is in many different types of editing programs where a mouse click may have completely different commands to execute (using the Command Pattern)
Currently I have an overarching ...
3
votes
7answers
204 views
Naming guard clauses that throw exceptions
I have a function evaluate() that parses a String for some variables and replaces them with their corresponding value:
public String evaluate() {
String result = templateText;
for ...
4
votes
2answers
275 views
Is it possible to avoid enormously big switch in that case? [duplicate]
I'm writing a simple chess-related code with intention to write it clearly (performance doesn't matter at all). And this method I have doesn't look clean to me at all:
public static Piece ...
5
votes
2answers
164 views
How to do unit tests on a method that takes the elapsed time into account?
I'm currently in the middle of refactoring an important method in a legacy-system. There were almost zero test until I've started working on it, and I've added quite a lot to ensure the correct work ...
4
votes
3answers
172 views
How should I go about “overhauling” a large legacy application? [duplicate]
Possible Duplicate:
I’ve inherited 200K lines of spaghetti code — what now?
For my next project, I've been tasked with "overhauling" a large legacy web application with many parts. It is a ...
4
votes
3answers
217 views
Renaming long named method in C# [closed]
I'm working on a project where exist one method with title
string ValidateNewPasswordExpireCurrentPasswordAndCreateNewPassword(...)
I'm sure the method name must be changed. But can't found good ...
0
votes
4answers
258 views
How to refactor such code? [closed]
The project is full of such code and the function is really long and hard to understand..
How to refactor?
int get_greate_structure(GreateStructure* st)
{
switch (st->type)
{
case 1:
...
7
votes
3answers
453 views
Cleaning Up Generated Code: Refactor or Map?
Context:
I recently had to deal with a class file generated by XSD.exe. It was 3500 lines long with ridiculously-verbose class / variable names (think ...
2
votes
2answers
195 views
How to remove duplicate exception block code
I have good number of Service and DAO classes which has the same set of 30 line exception code block which gets repeated and it shows up in Code Duplication report.
The approach which i can think of ...
0
votes
0answers
209 views
Is there an alternatives to Visual Studio's Visual Assist X plug-in for Mac? [closed]
Are there any text-editors, or plug-ins for text-editors that will implement a C++ function/method automatically for you? Then I wont have have to copy and paste re-type the method/function out every ...
2
votes
2answers
151 views
Overcoming circular reference
I am working on an asp.net MVC web application which contains several projects.
One is BusinessObjects, which contains business logic / processes.
Another is EmailGeneration which is used to send ...
2
votes
0answers
99 views
Tools for finding unused files in web application [closed]
Is there any tools to find unused js, css and image files in web application?
Something like Resharper for these files.
I've a web application developed by someone else; He has included a lot of js ...
0
votes
1answer
119 views
JavaScript refactoring tool [closed]
I'm on the process of refactoring a large JavaScript application, which has a lot of repeated functions with 2 or 3 different parameters, a lot of global variables used in several modules, etc.
Which ...
5
votes
8answers
379 views
Refactoring: Two big chunks within a function
I am designing an API which mostly involves refactoring the original code.
So Right now I have a method which has two big chunks which are seperated by an If-else condition, which in my opinion is ...
9
votes
7answers
767 views
Temporary variables vs line length requirements
I've been reading Martin Fowler's Refactoring. It is generally excellent but one of Fowler's recommendations seems to be causing a little trouble.
Fowler recommends that you replace temporary ...
4
votes
3answers
205 views
How to refactor “nested” view classes to avoid deep method calls?
Lets say I'm displaying a bunch of data (model) using a View class for rendering. However, a lot of the data has sub-data (models) complicated enough to require separate rendering classes.
In my ...
-1
votes
5answers
243 views
What do you do to overcome the need to make code perfect? [closed]
I'm sure I'm not the only one in this situation and I wanted to see what you guys do about this on day-to-day basis. Sorry if this comes off a bit ranty.
As a company founder and the main tech guy, I ...
1
vote
1answer
115 views
How to avoid huge functions with made up of enums and if-else or switch case when dealing with server response in iOS?
in my application,
I have a request type associated with variety of API calls I make to the REST server.
when the response from server comes in the same delegate method for web engine's response,
I ...
0
votes
1answer
138 views
How To Explain Need to Refactor Code to Non-Developer Boss [duplicate]
Possible Duplicate:
How do you explain refactoring to a non-technical person?
How to justify code refactoring time?
My supervisor is the CTO of the company that I work at, he is the jack ...
16
votes
5answers
950 views
How do I prevent unknowningly duplicating code?
I work on a rather large code base. Hundreds of classes, tons of different files, lots of functionality, takes more than 15 minutes to pull down a fresh copy, etc.
A big problem with such a large ...
8
votes
2answers
163 views
Refactoring several huge C++ classes / methods. How to start? [duplicate]
Possible Duplicate:
I’ve inherited 200K lines of spaghetti code — what now?
I'm dealing with legacy code. It contains some BIG classes (line count 8000+) and some BIG methods (line count ...
9
votes
1answer
174 views
Looking for the better way to combine deep architecture refactoring with feature based development
Problem statement:
Given:
TFS as Source Control
Heavy desktop client application with tons of legacy code with bad or
almost absent architecture design.
Clients constantly requiring new features ...
1
vote
1answer
99 views
Is it justified to use project-wide unique function and variable names to help future refactoring?
Refactoring tools (like ReSharper) often can't be sure whether to rename a given identifier when, for example refactoring a JavaScript function. I guess this is a consequence of JavaScript's dynamic ...
7
votes
4answers
352 views
Would you refactor this and if so, would you charge your client?
I am working on a freelance job at home. The client wants me to write some new functionality for his CMS, but it is taking me a lot of time to figure out what the code is doing, because it is written ...
0
votes
2answers
184 views
Question on refactoring and code design
Suppose, I have a class with a constant static final field. Then I want in certain situations that field to be different. It still can be final, because it should be initialized in constructor. My ...
2
votes
4answers
276 views
Can notes/to-dos in code comments sent to code-reviews result in an effective refactoring process?
I want to start/improve a culture of collective code ownership at my company but at a geographically distributed level... I'd say there is some current collective code-ownership mentality, but only at ...
20
votes
5answers
1k views
What is the politically correct way of refactoring other's code?
I'm currently working in a geographically distributed team in a big company. Everybody is just focused on today's tasks and getting things done, however this means sometimes things have to be done the ...
4
votes
1answer
184 views
Music Notation Editor - Refactoring view creation logic elsewhere
Let me preface by saying that knowing some elementary music theory and music notation may be helpful in grasping the problem at hand.
I'm currently building a Music Notation and Tablature Editor (in ...
2
votes
2answers
279 views
How Visual Studio could help to avoid duplicating code?
I work within a team of developers. Everyone is making their changes without carrying too much if the same thing is already implemented in the codebase. This leads to classes constantly growing and to ...
-1
votes
1answer
94 views
Good way to extract strings to resource [closed]
I am using Visual Studio 2010 and we just decided to get started on localization of our code. We want to use the per-form resource file in combination with a separate resource file for static strings, ...
14
votes
8answers
536 views
Quantifying the value of refactoring in commercial terms
Here is the classic scenario; Dev team build a prototype. Business mgmt like it and put it into production. Dev team now have to continue to deliver new features whilst at the same time pay the ...
3
votes
1answer
163 views
Refactoring obscurely commented code
In refactoring code, I came across code that had comments. Looking closer at the comments, I could see that the code was clearly not doing what the comments said.
Without access to the coder nor ...
6
votes
6answers
398 views
Refactoring and Open / Closed principle
I have recently being reading a web site about clean code development (I do not put a link here because it is not in English).
One of the principles advertised by this site is the Open Closed ...
8
votes
4answers
277 views
Rapid prototyping and refactoring
Sometimes when I start a small project (like an android app), I don´t know which approach will work out at the end, and I just go for one approach and give it a try. But if I never used this approach ...
4
votes
4answers
142 views
How to implement isValid correctly?
I'm trying to provide a mechanism for validating my object like this:
class SomeObject {
private $_inputString;
private $_errors=array();
public function __construct($inputString) {
...
2
votes
1answer
308 views
Recovering an anemic domain model into a multitier architecture
I have spent the past several days learning about domain driven design and attempting to apply it to a current project. I decomposed the problem domain into the canonical logical components: domain, ...
0
votes
1answer
109 views
Persuading management that refactoring code is a good idea [duplicate]
Possible Duplicate:
Best supporting argument for refactoring
Has anyone got any tips for persuading management that refactoring code is a good idea ? I was asked something like
"After ...
3
votes
1answer
89 views
Naming a class that processes orders
I'm in the midst of refactoring a project. I've recently read Clean Code, and want to heed some of the advice within, with particular interest in Single Responsibility Principle (SRP).
Currently, ...
3
votes
3answers
304 views
How to deal with almost the same enums?
I need to define enums in several classes. The majority of fields are the same in all of the enums. But one has one or two more fields, another has fewer fields. Now I wonder what is the best way to ...
0
votes
3answers
225 views
Introduce unit testing when codebase is already available [duplicate]
Possible Duplicate:
Best practices for retrofitting legacy code with automated tests
I've been working on a project in Flex for three years now without unit testing. The simple reason for ...
3
votes
1answer
265 views
Replacing out parameters with struct
I'm encountering a lot of methods in my project that have a bunch of out parameters embedded in them and its making it cumbersome to call the methods as I have to start declaring the variables before ...
4
votes
2answers
203 views
What is the right way to group this project into classes?
I originally asked this on SO, where it was closed and recommended that I ask it here instead. I'm trying to figure out how to group all the functions necessary for my project into classes. The goal ...
0
votes
2answers
189 views
Breaking up a large PHP object used to abstract the database. Best practices?
Two years ago it was thought a single object with functions such as $database->get_user_from_id($ID) would be a good idea. The functions return objects (not arrays), and the front-end code never ...
3
votes
6answers
515 views
What to do when you inherit an unmaintainable codebase? [duplicate]
Possible Duplicate:
Techniques to re-factor garbage and maintain sanity?
I've inherited 200K lines of spaghetti code — what now?
I'm currently working at a company with 2 other ...
4
votes
3answers
618 views
How do I break down and plan a personal programming project? [closed]
I've just started a programming job where I'm applying my 'How to code' knowledge to what I'm being taught of 'How to Program' (They are different!). As part of this, I've been taught how to capture ...
6
votes
7answers
352 views
Is there such thing like a “refactoring/maintainability group” role in software companies?
So, I work in a company that does embedded software development, other groups focus in the core development of different products' software and my department (which is in another geographical ...
6
votes
3answers
145 views
What do I need to learn to decide on rename/recompile source package names because of company rebranding?
My company is currently at a rebranding process and the brand names have been used in the sources' package names but these names are only visible to developers who maintain this code so nobody from ...
4
votes
3answers
389 views
CTO has left — codebase is a huge kludge, any advice on how to manage/handle/damage control? [closed]
I began work at a company 2 months ago as a PHP developer. I stepped in to somewhat of a kludge, but I've yet to find a company that isn't... The development stable is currently two developers ...
9
votes
4answers
372 views
How to unit test a function that is refactored to strategy pattern?
If I have a function in my code that goes like:
class Employee{
public string calculateTax(string name, int salary)
{
switch (name)
{
case "Chris":
...
13
votes
7answers
689 views
Using functions as a way to stylize
Have you ever broken up a large function into smaller functions knowing that those smaller functions will not be called by more than one caller? The primary purpose of a function is to promote code ...
