mysql_fetch_array error when using WHERE clause

Question

Im using:

$query = "SELECT * FROM mydb WHERE condition = New ORDER BY id ASC";

but i get this error:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/mydb.php on line 84

however if i remove the where clause it works perfectly, can anyone point me in the right direction?

Is the Where clause not usable when doing a fetch array? Thanks for any help.

edit: error message I've got:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'condition = 'New' ORDER BY id ASC'

Answer 1

always run all your queries this way (at least until you adopt some intelligent lib for this)

$query  = "SELECT * FROM mydb WHERE condition = New ORDER BY id ASC";
$result = mysql_query($query) or trigger_error(mysql_error()." in ".$query);

just because not a single soul in the world can tell what's wrong with your query, but database itself. So, you have to ask it if there were any trouble. Not stackoverflow community (they have no idea anyway) but your db server. That's the point.

Note that you have to be able to watch errors occurred, either on-screen or in the error log.

After getting error message about syntax error you have to check syntax of the displayed query. If there are no visible errors, refer to http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html in case there are reserved word unescaped in your query. condition seems is. So

$query  = "SELECT * FROM mydb WHERE `condition` = New ORDER BY id ASC";

will be solution

Answer 2

You appear to be missing quotes around the word "New".

$query = "SELECT * FROM mydb WHERE condition = 'New' ORDER BY id ASC";

Also, are you passing $query to mysql_fetch_array, or did you just not mention the mysql_query call in your question?

Answer 3

Since you have tried adding single quotes to the ('New'),

1. kindly ensure that the condition is a column in the table you are querying and

2. that mydb is a table in your database (and not your database name)!

Answer 4

You have to quote the string.

$query = "SELECT * FROM mydb WHERE `condition` = 'New' ORDER BY id ASC";

Edit:

condition is a reserved word.

Answer 5

Is New one of your columns or just a value? Try this:

$query = "SELECT * FROM mydb WHERE condition = 'New' ORDER BY id ASC";

Answer 6

$query = "SELECT * FROM mydb WHERE condition = 'New' ORDER BY id ASC";
$result = mysql_query( $query );
while( $row = mysql_fetch_array( $result ) {
    // use $row
}

Answer 7

Never assume that a query will work - expect errors and check for them before processing any results.

$query = 'SELECT * FROM `mydb` WHERE `condition` = "New" ORDER BY `id` ASC';
$result = mysql_query( $query );

if( !$result ){
  // Query Failed. You can access the error details with mysql_error()
}elseif( mysql_num_rows( $result )==0 ){
  // Query Returned No Results
}else{
  while( $r = mysql_fetch_assoc( $result ) ){
    // Do whatever you want with the row, which is $r
  }
}