PHP Query String - parameter duplicates

Question

This is the code i use for creating pagination links:

echo "<a href='".$_SERVER['PHP_SELF']."?".$_SERVER["QUERY_STRING"]."&page=$ni'><span>$ni</span></a>";

The only problem is that every time i click the link, the 'page' parameter keeps multiplying in the URL:

http:..php?para1=something&para2=something&para3=something&page=2&page=3&page=4

I can undestand why. Another 'page' parameter is added to existing URL every time i click the link.

Any ideas how to solve it?

Thanks

Never, ever use $_SERVER['PHP_SELF'] without at least htmlencodeing it first. Otherwise, your code is very susceptible to PHP injection. Same thing with any of the $_SERVER variables that can come from the client, really. — Palladium
– Palladium, Commented Jul 31, 2012 at 14:12

Pablo Santa Cruz · Accepted Answer · 2012-07-31 14:06:25Z

3

Do not append .$_SERVER["QUERY_STRING"]. every time your page loads.

Just use this:

echo "<a href='".$_SERVER['PHP_SELF']."?page=$ni'><span>$ni</span></a>";

If you need another parameter from QUERY_STRING, add it independently to your URL.

I.E.:

echo "<a href='".$_SERVER['PHP_SELF']."?page=$ni&para1=something...'><span>$ni</span></a>";

answered Jul 31, 2012 at 14:06

Pablo Santa Cruz

182k33 gold badges250 silver badges300 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jose Vega · Accepted Answer · 2012-07-31 14:09:43Z

0

On your sample code:

$_SERVER["QUERY_STRING"] = para1=something&para2=something&para3=something&page=2&page=3&page=4

so when you are creating your link and pre-append $_SERVER["QUERY_STRING"] to &page=$ni, your link is really

para1=something&para2=something&para3=something&page=2&page=3&page=4&page=$ni

answered Jul 31, 2012 at 14:09

Jose Vega

10.3k7 gold badges43 silver badges58 bronze badges