current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I am running a web crawler for my own use. I downloaded one and want to provide it with seeds. I want to provide it with around 50 seeds. So I created an array of strings. I want to provide the crawler with 1 seed each time it goes through my for loop. My code is :

String[ ] temp = new String[ ] {"http://www.random.org/","http://www.wikipedia.org/", "http://www.jlworld.com/","http://www.frys.com/"};

String[ ] urls = new String[temp.length];

  for (int i = 0; i <=temp.length; i++)       
     {          
        urls[i] = temp[i];      
     }

The crawler needs a string assigned to urls. So like :

String[ ] urls = new String[1];

urls[0] = "http://www.google.com/";

So it works like that. I get an outofbounds exception though for my code. What I want to do is provide the crawler with 1 of the seeds each time it goes through the for loop. Any help on this would be appreciated!

share|improve this question
 
As a side note, instead of using the loop yourself, look into System.arraycopy (download.oracle.com/javase/1.4.2/docs/api/java/lang/…) –  corsiKa Feb 21 '11 at 19:21
add comment

6 Answers

up vote 4 down vote accepted 
for (int i = 0; i <=temp.length; i++)

Should be:

for (int i = 0; i <temp.length; i++)
share|improve this answer
 
Thanks everyone, I just figured it out too haha :) –  Eric Feb 21 '11 at 18:52
add comment
up vote 2 down vote 
for(int i = 0; i < temp.length; i++)

Calling .length on an array returns the size of the array, but array indices are 0-based. For your loop, you were correct in starting with i = 0, but you only want to go to i = (temp.length - 1) or you will get an index out of bounds exception. Comparing i < temp.length instead of i <= temp.length accounts for this shift in index basing.

share|improve this answer
 
There's no such thing as an "1-based size". The size is the size. If there are 10 elements in the array then the size is 10. Simple. –  Jesper Feb 21 '11 at 18:48
 
@Jesper Good point, I'll edit to clairfy –  Dave McClelland Feb 21 '11 at 18:53
add comment
up vote 0 down vote 
for (int i = 0; i < temp.length; i++) {          
    String url = temp[i];      

    ... handle url...
}
share|improve this answer
add comment
up vote 0 down vote

Why not have a Map of [URL, seed] pairs instead of raw arrays? Do the lookup using the URL and off you go.

share|improve this answer
add comment
up vote 0 down vote

Code should be

 for (int i = 0; i <temp.length; i++)       
 {          
    urls[i] = temp[i];      
 }

Array index start from 0 to length-1

share|improve this answer
add comment
up vote 0 down vote

Change the line 

for (int i = 0; i <=temp.length; i++)

to

for (int i = 0; i < temp.length; i++)

You were looping one too many times

share|improve this answer
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.