current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote -1 down vote favorite
1

i m trying to convert php mysql_fetch_row result into javascript array so i write below code to do that. but i got problem , if there are multiple row in result, then only last row stored in javascript array

<script>
function sub()
{
alert("coming");
var a= new Array;
<?php
$dbhost ='localhost';
$dbuser = 'root';
$dbpass = '';
$dbname = 'pupilcafe';
$conn = mysql_connect($dbhost,$dbuser,$dbpass) or die ('Error Connecting to mysql');
mysql_select_db($dbname,$conn);
$uid=1;
$semester='1stSemester';    
$cid=1;
$qry="select * from subject where cid='$cid'&& uid='$uid'&& semester='$semester'";
$res = mysql_query($qry);
while($data=mysql_fetch_row($res))
{
$i=0;
echo "a[$i]='".$data[1]."';";
$i++;
}
?>
alert(a[0]);
}
</script>

so here mysql code fetch two row frm db (Englishphp) but in result i got only php .. i want both of this row in javascript array so how to do that?

share|improve this question
add comment

2 Answers

up vote 1 down vote accepted

Don't concoct Javascript syntax yourself. Use json_encode:

$a = array();
while ($data = mysql_fetch_row($res)) {
    $a[] = $data[1];
}

?>

<script>
    var a = <?php echo json_encode($a); ?>;
</script>

Also, mysql_ functions are deprecated. Don't use them for new code. Use mysqli or PDO.

share|improve this answer
    
Thank you so much... its work gr8 :-) –  Jaydipsinh Oct 31 '12 at 7:09
add comment
up vote 0 down vote

First of all, you should follow some guidelines on coding. Your way of coding is not neat. Stop using mysql_query. It is getting depreciated and start using PDO. Search in google about that. Second, you should escape your variables that you are using in your query to avoid sql injection. What you want cannot be achieved with the code you have written. 

function sub() {

    //your queries and other stuff here

    while($data=mysql_fetch_row($res))
    {

        $tempArray[] = $data;

    }

    return json_encode($tempArray);
}
?>

<script language = "javascript">

    window.addEventListener("onload", function () {
        var temArray = "<?php echo sub(); ?>";

        alert(tempArray);

    }, false);

</script>

The onload eventListener will tell if the page is loaded. Without that it mightbe possible that your function call sub() might give you an error "undefined function" because its not yet loaded.

share|improve this answer
    
Thanks Abhishek.! ya i will search about pdo also –  Jaydipsinh Oct 31 '12 at 7:11
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.