up vote 0 down vote favorite

Same as the title and using C#. Anyone know how to do this? I have a bunch of data read into a list box but the data doesn't refresh unless I restart the windows form. anyone know how to refresh it on a button click event? 

   {

                SqlConnection conn = new SqlConnection();
                conn.ConnectionString = (@"Data Source=.\SQLEXPRESS;AttachDbFilename=C:\Users\John\Desktop\DB\DB\DB\setup.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True");
                conn.Open();

                SqlCommand cmd = new SqlCommand
                ("SELECT PEOPLE " + "FROM Workers", conn);

                try
                {
                    SqlDataReader sdr = cmd.ExecuteReader();

                    while (sdr.Read())
                    {
                        listBox1.Items.Add(sdr["people"].ToString());
                    }

                    sdr.Close();
                }

                catch (SqlException ex)
                {
                    MessageBox.Show(ex.Message);
                }

                finally
                {
                    conn.Close();
                }

            }

This is in windows form Load. So i'm looking to add a button on my form which refreshes the listbox items list

share|improve this question
where did you put your code? Please commit part of your code! – MUG4N Apr 28 '12 at 22:06
all right sorry, i'll edit it – user1353517 Apr 28 '12 at 22:10
edited with code :) – user1353517 Apr 28 '12 at 22:15
Put that code in a method(f.e. "getWorkers") and call it from form's load and button's click event-handlers. – Tim Schmelter Apr 28 '12 at 22:15
Sorry i'm a bit of a newbie, i've created the class but how do I call it? – user1353517 Apr 28 '12 at 22:23

2 Answers

up vote 2 down vote accepted

Add a Method 

private void ShowPeople()
{
    // Put your code;
}

and then use the same in your button click

private void Button_Click(object sender,EventArgs e)
{
    ShowPeople();
}
share|improve this answer
Great thanks! works a treat – user1353517 Apr 28 '12 at 22:36
You should at least have named the method better(f.e. private IList<String> getWorkers() or private void addWorkers()) – Tim Schmelter Apr 28 '12 at 22:38
up vote 0 down vote

To reload data over your sqldatareader (at least I guess you mean set by using the word "refresh") by pressing a button you simply have to access the database again with the same code you are already using. But the important point here is, that you are using a bad design. Therefore I point out an article (30 mins to read) which helped me a lot to improve my code and therefore got rid of code duplication.

Please read: http://imar.spaanjaars.com/416/building-layered-web-applications-with-microsoft-aspnet-20-part-1

After you have read this article I will promise you that you will have a better understanding of how you have to access data in the database within your application

share|improve this answer
Why is "SELECT PEOPLE " + "FROM Workers" open for SQL-Injection? There's not even one parameter in this sql query. It's the same as SELECT PEOPLE FROM Workers (what OP should use to avoid misunderstandings). – Tim Schmelter Apr 28 '12 at 22:26
you are right I will correct this – MUG4N Apr 28 '12 at 22:30
Thanks for the tips ^^. @TimSchmelter how do I call the method i've just created from form load and the button click? – user1353517 Apr 28 '12 at 22:30

Your Answer

 
or
required, but never shown
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.