Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I need to insert array data into MySQL DB. My code is provided below. The problem is that query is equal to

INSERT INTO MyTab (Array) VALUES (Array,Array,Array,Array,Array,Array,Array,Array,Array,Array,Array)

So, why do I get Array instead of array values?

$columns = array();
    $values = array();

    $columns[] = array('Num','appearanceTime');

    $curr_time = new DateTime();
    while($row=mysql_fetch_assoc($result_arr)) {
        $values[] = array($row['Num_arr'],$curr_time);
    }

    $cols = implode(",",$columns);
    $vals = implode(",",$values);

$query = "INSERT INTO `MyTab` ($cols) VALUES ($vals)";

UPDATE This code returns Internal Server Error at the line $vals = implode(...).

$columns = array('Num','appearanceTime','earliestTime'); $values = array();

$curr_time = new DateTime();
while($row=mysql_fetch_assoc($result_arr)) {
    $values[] = array($row['Num_arr'],$curr_time,$row['ETA']);
}

$cols = implode(",",$columns);

function get_values($arr) {
return '(' . implode(',', $arr) . ')';
}

$vals = implode(',', array_map('get_values', $values));

$query_queue = "INSERT INTO `MyTab` ('" . $cols . "') VALUES ('" . $vals . "')";
share|improve this question
Because they're arrays? – rynah♦ Aug 26 '12 at 15:28
Try to remove the brackets after $columns – Peter Aug 26 '12 at 15:28

1 Answer

up vote 2 down vote accepted

The values inside the arrays are arrays. You need to implode each of them, too:

$vals = implode(',', array_map(function($arr) {
    return '(' . implode(',', $arr) . ')';
}, $values));

As for the columns, I think you want:

$columns = array('Num','appearanceTime');
$values = array();

Not:

$columns = array();
$values = array();

$columns[] = array('Num','appearanceTime');

You'll also need to quote everything to put it in the query. You should use PDO or MySQLi and prepared statements instead of mysql_ if you can.

Given PHP 5.2, the first example needs to be changed to:

function implode_comma($arr) {
    return '(' . implode(',', $arr) . ')';
}

# ...

$vals = implode(',', array_map('implode_comma', $values));
share|improve this answer
Thanks,I tried your updates. This one contains some syntax error: $vals = implode(',', array_map(function($arr) { return '(' . implode(',', $arr) . ')'; }, $values)); Do you know what's the problem here? – You Kuper Aug 26 '12 at 15:35
Also, what is '$arr'? Is it a new variable? Or does it correspond to some of my variables? – You Kuper Aug 26 '12 at 15:39
@YouKuper: That's an anonymous function. Which version of PHP are you using? If it's less than 5.3, you'll need to change that into a real function and use array_map('your_function', $values) instead. – rynah♦ Aug 26 '12 at 15:46
I'm using PHP 5.2.14 – You Kuper Aug 26 '12 at 15:50
@YouKuper: See update. – rynah♦ Aug 26 '12 at 15:53
show 8 more comments

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.