current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I have the following code which works:

$date1 = mysql_query("SELECT date1 FROM Users WHERE username='".$_SESSION['username']."'") 
    or die(mysql_error());
while($row = mysql_fetch_array($date1)){
    $lastViewedDate = $row[0];
}

But when I try to use mysql_fetch_object I get an Internal Server Error 500.

$date1 = mysql_query("SELECT date1 FROM Users WHERE username='".$_SESSION['username']."'") 
    or die(mysql_error());
while($row = mysql_fetch_object($date1)){
    $lastViewedDate = $row["date1"];
}

I would prefer to use the objects in the future but I don't understand why they aren't working. Any help would be appreciated.

share|improve this question
3  
Please, don't use mysql_* functions to write new code. They are no longer maintained and the community has begun deprecation process. See the red box? Instead you should learn about prepared statements and use either PDO or MySQLi. If you can't decide which, this article will help you. If you pick PDO, here is good tutorial. –  Second Rikudo Sep 14 '12 at 18:28
1  
Inserting user data directly into your query is a very bad idea. Always use SQL placeholders as supported by mysqli or PDO. –  tadman Sep 14 '12 at 18:29

3 Answers 3

up vote 4 down vote accepted

With fetch_object the syntax is :

$row->date1

with fetch_assoc the syntax is:

$row["date1"]

Also please.. for everything that is holy.. Turn E_NOTICE error messaging and display_errors on

share|improve this answer
    
Thanks for the info. As a PHP noob I didn't even know about the E_NOTICE errors. I looked it up and it looks like I just need to call this at the beginning of the script. error_reporting(E_ERROR | E_WARNING | E_PARSE | E_NOTICE); Is that what you are talking about? –  FuegoFingers Sep 14 '12 at 19:05
1  
@FuegoFingers: yes that call will help. It's even better to put in your php.ini, because certain errors may already get triggered, before you get a chance to call that function. –  Evert Sep 16 '12 at 15:05
    
Ok will do. Thanks for the info and the help. –  FuegoFingers Sep 18 '12 at 15:07
up vote 1 down vote

You are not accessing your object correctly it would be like this:

$date1 = mysql_query("SELECT date1 FROM Users WHERE username='".$_SESSION['username']."'") 
    or die(mysql_error());
while($row = mysql_fetch_object($date1)){
    $lastViewedDate = $row->date1;
}

Note the use of the object property accessor ->

share|improve this answer
    
Not sure why this got downvoted. –  Second Rikudo Sep 14 '12 at 18:31
1  
Probably because it continues to promote a SQL injection vulnerability .. would be my guess. The other answers simply omit showing/talking about it and thus don't "promote" such code, even if they don't "discourage" it either. –  user166390 Sep 14 '12 at 19:23
    
I felt the question was really more about accessing the properties of the object rather than the database access aspect. Thus, I just copied OP's code as is with single change made. Comments on the question had already made the typical "don't use mysql-*" suggestions. –  Mike Brant Sep 14 '12 at 19:31
up vote 1 down vote 
$lastViewedDate = $row["date1"];

That's not how you access an object's variables; try this:

$lastViewedDate = $row->date1;
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.