current community

your communities

more stack exchange communities

company blog
Stack Exchange Inbox Reputation and Badges
tour help
Stack Overflow is a community of 4.7 million programmers, just like you, helping each other.

Join them; it only takes a minute:

Sign up
Join the Stack Overflow community to:
  1. Ask programming questions
  2. Answer and help your peers
  3. Get recognized for your expertise
up vote 0 down vote favorite

I am doing a tutorial on PHP. I am in the update section of the CRUD lesson and am working on a validation script. I have followed the code exactly... I think but still not working correctly. Here is the problem: When I click submit to try to test the validation with the menu name field empty it goes through without an error... and updates the nav with an empty list item? I have looked over the code and all seems to be correct but I am very new to this so problems are easily overlooked.

Here is the code:

if(isset($_POST['submit'])) {
    $errors = array();

    $required_fields = array('menu_name', 'position', 'visible');   
    foreach($required_fields as $fieldname) {
        if(!isset($_POST[$fieldname]) || (empty($_POST[$fieldname]) && $_POST[$fieldname] != 0) ) {
            $errors[] = $fieldname;
        }
    }

    if(empty($errors)) {
        //Perform Update
        $id = mysql_prep($_GET['subj']);
        $menu_name = mysql_prep($_POST['menu_name']);
        $position = mysql_prep($_POST['position']);
        $visible = mysql_prep($_POST['visible']);

        $query = "UPDATE subjects SET
                    menu_name = '{$menu_name}',
                    position = {$position},
                    visible = {$visible} WHERE id = {$id}";

        $result = mysql_query($query, $connection);

        if(mysql_affected_rows() == 1){
            // success
            $message = "Subject was sucessfully updated"; 
        }else{
            $message = "The subject update failed.";
            $message .= "<br />" . mysql_error();
        }
    }else{
        //error occured
        $message = "There were " . count($errors) . " errors in the form.";
    }
} // end if(isset($_POST['submit']) )
?>

And the code from the body:

<h2>Edit Subject: <?php echo $sel_subject['menu_name']; ?></h2>
<?php 
    if(!empty($message)){
        echo "<p class=\"message\">" . $message . "</p>";
    }
?>
<?php
    if(!empty($errors)){
        echo "<p class=\"errors\">";
        echo "Please review the folowing fields: <br />";
        foreach($errors as $error){
            echo "-" . $error . "</p>";
        }
    }
?>

Now when I change (empty($_POST[$fieldname]) to (empty($_POST['menu_name']) it spits out errors but they are for the position and visible fields which happen to be correct...? Is there a character left out that I just cannot see. I have done mostly copy and paste to prevent those stupid kind of mistakes.. Note: that the validation for position and visible do work... I think... since you cannot leave those fields blank anyway how would I know...

Any help is greatly appreciated.

share|improve this question
    
Have you tried echoing out the SQL query so you can make sure it looks like what you think it should? – andrewsi Aug 16 '12 at 17:23
    
Can you give more more info, can you do a var_dump($_POST) in the top of the code and provide the output? – everlof Aug 16 '12 at 17:23
    
the dump gives me this: array 'menu_name' => string '' (length=0) 'position' => string '7' (length=1) 'visible' => string '1' (length=1) 'submit' => string 'Edit Subject' (length=12) – EZDC Aug 16 '12 at 17:40
up vote 2 down vote accepted

The error is right here:

$_POST[$fieldname] != 0

An empty string = 0 because 0 is false. So in your if statement, you say if it is empty (which it is) AND NOT equal to 0 (which it does).

What you can do is

  1. Drop the !=0 statement completely as empty will do a grand job checking that.
  2. Use the correct operator: !=="0", if you want to accept "0" as an option.

When you use 3 equals or !== it validates against the type. 0===0, and 0==false, "0"==0, "0"==false, and false===false, BUT 0!==false, 0!=="0" and "0"!==false. I hope that makes sense.

EDIT

Lets run this down into the ground a little further with a series of tests.

$a='';
$b="0";
if(empty($a))
    echo'$a is empty<br/>';
if(empty($b))
    echo'$b is empty<br/>';
if($a!=0)
    echo'$a does not equal 0/false<br/>';
if($b!=0)
    echo'$b does not equal 0/false<br/>';
if($a!==0)
    echo'$a does not equal integer 0<br/>';
if($b!==0)
    echo'$b does not equal integer 0<br/>';
if($a!=="0")
    echo'$a does not equal string 0<br/>';
if($b!=="0")
    echo'$b does not equal string 0<br/>';

The output above would be

$a is empty
$b is empty
$a does not equal integer 0
$b does not equal integer 0
$a does not equal string 0

Conclusions: $a==$b, $a!==$b. $a AND $b are == to 0 and == to false, neither of them are integers, both are strings, and an empty string is not the same as a string containing the 0 character.

Change $_POST[$fieldname]!=0 to $_POST[$fieldname]!=="0"

share|improve this answer
    
$_POST[$fieldname] will never === 0. – Waleed Khan Aug 16 '12 at 18:03
    
Very true, it will always be a string, so it should probably just be dropped. – Tim Withers Aug 16 '12 at 18:07
    
The video says that $_POST[$fieldname] != 0) is used for the visible field since visibility off is = 0 then you would get an error... make sense? – EZDC Aug 16 '12 at 18:25
    
Change it to: !=="0" since it is a string that the field submits, probably equal to either "0" or "1". The video lead you astray. – Tim Withers Aug 16 '12 at 18:31
    
@user980988 I beat the proverbial dead horse for you. – Tim Withers Aug 16 '12 at 18:45

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.