Strings in Javascript Array [closed]

Question

Closed. This question needs details or clarity. It is not currently accepting answers.

Want to improve this question? As written, this question is lacking some of the information it needs to be answered. If the author adds details in comments, consider editing them into the question. Once there's sufficient detail to answer, vote to reopen the question.

Closed 11 years ago.

Improve this question

My array looks like this:

var imagetitle = new Array()
imagetitle[0] = "One two tree";
imagetitle[1] = "Zero One seven abc";
imagetitle[2] = "qwe qwe qwe";
imagetitle[3] = "rerere erere weqwe";

Imagetitle is used as title in HTML later. Problem is that when I use it like this, It display only 1st word of string, not full string.

function showimage() {
var div_sa_slikom = document.createElement("div");
div_sa_slikom.innerHTML = "<a href="+imagetarget[i_image]+" title="+imagetitle[i_image]+" target='_parent'><img style='border:none;' src="+imageurl[i_image]+" border='0' title="+imagetitle[i_image]+" alt="+imagetitle[i_image]+" /></a>";
var container = document.getElementById("slike_rotator");
container.appendChild(div_sa_slikom);
}

You'll have to show us the part where you use it - there's nothing wrong with what you've posted. — Pointy
– Pointy, Commented Oct 28, 2012 at 14:33
You're missing a semi colon in the above - doubt that's related though; probably just a typo in the question. var imagetitle = new Array(); — JohnLBevan
– JohnLBevan, Commented Oct 28, 2012 at 14:34

Denys Séguret · Accepted Answer · 2012-10-28 15:07:00Z

5

Your problem is that the HTML you're building is missing quotes.

You're building

title=One two tree

instead of

title="One two tree"

Replace your function with

function showimage() {
   var div_sa_slikom = document.createElement("div");
   div_sa_slikom.innerHTML = '<a href="'+imagetarget[i_image]+'" title="'+imagetitle[i_image]+'" target="_parent">'
       + '<img style="border:none;" src="'+imageurl[i_image]+'" border=0 title="'+imagetitle[i_image]+'" alt="'+imagetitle[i_image]+'">'
       + '</a>';
   var container = document.getElementById("slike_rotator");
   container.appendChild(div_sa_slikom);
}

edited Oct 28, 2012 at 15:07

answered Oct 28, 2012 at 14:41

Denys Séguret

384k90 gold badges811 silver badges778 bronze badges

You probably didn't fix all quotes. I edited my answer with the complete function.

Denys Séguret
– Denys Séguret

10/28/2012 15:08:14
Commented Oct 28, 2012 at 15:08

Add a comment |

Collectives™ on Stack Overflow

Strings in Javascript Array [closed]

1 Answer 1

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Related