up vote -1 down vote favorite

I am trying to add new arrays to an existing array dynamically from a database but my loop is only adding the last row from mysql_fetch_row. I think it is actually overwriting the same array.

PHP Code

<?php
$con = require_once('./dbconnect.php');

global $con;
mysql_select_db("packages", $con);
$packages = mysql_query("SHOW TABLES FROM packages");

while($row = mysql_fetch_row($packages)){
    $node = array();

    foreach($row as $key2 => $value2){
        $node[$row[0]] = array("Item1" => "Other dynamic Info here");
    }
}

print_r($node);

mysql_close($con);
?>

The output is as follows:

Array
(
    [Pack1] => Array
        (
            [Item1] => Other dynamic Info here
        )

)

It should be outputting:

Array
(
    [Pack1] => Array
        (
            [Item1] => Other dynamic Info here
        )

)
Array
(
    [Pack2] => Array
        (
            [Item2] => Other dynamic Info here
        )

)

I have been trying to get this foreach() loop to work for about a day now...what am i doing wrong?

share|improve this question
1  
Well, you are overwriting $node = array() each time in the while loop. It will contain a single result after the while is finished. – alex.ac Nov 7 '12 at 15:49

4 Answers

up vote 0 down vote accepted

Declare 

$node = array();

outside the while loop.

If indexing of the node array is irrelevant you can just use the "append" notation

foreach($row as $key2 => $value2){
    node[] = array("Item1" => "Other dynamic Info here");
}
share|improve this answer
Awesome, worked like a charm! – user1784477 Nov 7 '12 at 19:03
up vote 0 down vote

Should be

foreach($row as $key2 => $value2){
    $node[$key2] = array("Item1" => "Other dynamic Info here");
}
share|improve this answer
up vote 1 down vote

Try To define the $node array outside the while loop as:

$node = array(); ## <-- HERE

while ($row = mysql_fetch_row($packages))
{    
    foreach ($row as $key2 => $value2) 
    {
        $array      = array("Item1" => "Other dynamic Info here");
        $key        = $row[0];
        $node[$key] = $array;
    }
}

You can also use var_dump to debug your code, so you find out more quickly when something goes wrong.

share|improve this answer
try to use mysqli.......... in place of mysql for connections – Vikas Umrao Nov 7 '12 at 16:05
up vote 0 down vote

You are overwriting the array on each cycle through the while loop, but only outputting the array once after the last cycle. Your code should be like the following (notice the position of print_r):

<?php
$con = require_once('./dbconnect.php');

global $con;
mysql_select_db("packages", $con);
$packages = mysql_query("SHOW TABLES FROM packages");

while($row = mysql_fetch_row($packages)){
    $node = array();

    foreach($row as $key2 => $value2){
        $node[$row[0]] = array("Item1" => "Other dynamic Info here");
    }
    print_r($node);
}

mysql_close($con);
?>

That will output the array on each cycle through the while loop.

share|improve this answer

Your Answer

 
or
required, but never shown
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.