|
Not really much else to say besides what's on the tin. The project was only recently launched and has yet to be promoted. Wanted some colleague eyeballs on this before pulling that trigger. https://github.com/JWT-OSS/Google-Geocoding-PHP-SDK-Unofficial |
|||||
|
|
WOW The code is organised, clean, dependable and great OOP, there is not much that you need to change but I do have a few suggestions that you may / may not be interested in but every little helps. The first minor issue is that as your using the The "feature" that I would like to see is a namespace, encapsulating all your code within its own specific scope, this would take care of little issues like the If you do decide to create a version which is based around a namespace I would also recommend that you take a look at the php team's proposal over @Google Groups and the class which should be modified to suite your perfectionist needs (Located Here) - Large vendors such as Zend and Doctrine also use the same proposal. Also the classes can be specifically name for there function without being prefixed with the vendor.
if you encapsulated within the namespace otherwise I see how much effort and thought you have put into the code and its a credit to the PHP World, im sure that google would feature this as an External SDK. Update: After reading your source code a little more in depth and trying to understand the work flow I come across another small change and that is allowing array and objects to be passed into the Regards. |
||||
|
