Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I am trying to make a simple number to english words program and I've decided to use arrays.

Its not displaying the loop iteration values in tens2 array, as i have declared it in string array. what to do if i want to display string array tens2 with particular loop iterated index.

What do I need to change to fix that? Here's my code;

static void Main(string[] args)
{

    Console.Write("Enter Number =");
    string n = Console.ReadLine();

    char[] num = new char[] { '1', '2', '3', '4', '5', '6', '7', '8', '9' };
    string[] unit = new string[] { "One", "Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine" };
    string[] tens = new string[] { "ten", "eleven", "twelve", "thirteen", "forteen", "fifteen", "sixteen", "seventeen", "eighteen", "nineteen" };
    string[] tens2 = new string[] { "","twenty", "thirty", "forty", "fifty", "sixty", "seventy", "eighty", "ninety" };


    if (n.Length == 4)
    {

        for (int a = 0; a < num.Length; a++)
        {
            if (n[0].Equals(num[a]))
            {
                Console.Write("{0}" + " " + "Thousand", unit[a]);
                break;
            }
        }
        for (int a = 0; a < num.Length; a++)
        {
            if (n[1].Equals(num[a]))
            {
                Console.Write(" {0}" + " " + "Hundred", unit[a]);
                break;
            }
        }
        for (int a = 0; a < num.Length; a++)

        {
            if (n[2]=='1' && n[3].Equals(num[a]))
            {
                Console.Write(" {0}",tens[a+1]);
                break;
            }
            else if (n[2].Equals('1') && n[3].Equals('0'))
            {
                Console.Write(" Ten");
                break;
            }
            else if (n[2]!='1' && n[3].Equals(num[a]))
            {
                Console.Write(" {0}"  , tens2[a]);
                break;
            }

        }
            for (int a = 0; a < num.Length; a++)
        {

            if ((n[3].Equals(num[a]) && (n[2]!='1')))
            {
                Console.Write(" {0}" , unit[a]);
                break;
            }
        }
    }
}

share|improve this question
What is the output? Does it throw an error? – Chris Cooney Apr 18 at 9:40
First comment - aside from the amazingly inefficient inner workings, this is a no-op for any number < 1000 or > 9999, since you have that if (n.Length == 4) condition at the beginning... – Shaul Apr 18 at 9:43
1  
Next comment - take a step back and ask if looping through arrays is really the way you want to go here. I'd suggest you Google "C# convert number to text". – Shaul Apr 18 at 9:49

2 Answers

up vote 0 down vote

For four figure numbers only:

string n = "5415";

int[] digits = n.Select(i => Int32.Parse(i.ToString())).ToArray();

string[] unit = new string[] { "one", "two", "three", "four", "five", "six", "seven", "eight", "nine" };
string[] tens = new string[] { "ten", "eleven", "twelve", "thirteen", "fourteen", "fifteen", "sixteen", "seventeen", "eighteen", "nineteen" };
string[] tens2 = new string[] { "", "twenty", "thirty", "forty", "fifty", "sixty", "seventy", "eighty", "ninety" };

StringBuilder sb = new StringBuilder();

sb.Append(unit[digits[0]-1]);
sb.Append(" thousand, ");

if (digits[1] > 0)
{
    sb.Append(unit[digits[1] - 1]);
    sb.Append(" hundred and ");
}

if (digits[2] > 1)
{
    sb.Append(tens2[digits[2] - 1]);
    sb.Append(" ");
    sb.Append(unit[digits[3] - 1]);
}
else if (digits[2] == 1)
{
    sb.Append(tens[digits[3]]);
}
else
{
    sb.Append(unit[digits[3] - 1]);
}
share|improve this answer
up vote 0 down vote

I modified @paul's code to make it little more robust:

    static void Main(string[] args)
    {
        Console.Write("Enter Number =");
        string n = Console.ReadLine();
        var sb = new StringBuilder();

        if (n.Length == 4)
        {
            if (int.Parse(n) <= 0)
            {
                sb.Append("Supply a positive integer number greater than zero.");
            }
            else
            {
                int[] digits = n.Select(i => Int32.Parse(i.ToString())).ToArray();

                string[] unit = new string[]
                    {"one", "two", "three", "four", "five", "six", "seven", "eight", "nine"};
                string[] tens = new string[]
                    {
                        "ten", "eleven", "twelve", "thirteen", "fourteen", "fifteen", "sixteen", "seventeen",
                        "eighteen",
                        "nineteen"
                    };
                string[] tens2 = new string[]
                    {"", "twenty", "thirty", "forty", "fifty", "sixty", "seventy", "eighty", "ninety"};

                if (digits[0] > 0)
                {
                    sb.Append(unit[digits[0] - 1]);
                    sb.Append(" thousand, ");
                }

                if (digits[1] > 0)
                {
                    sb.Append(unit[digits[1] - 1]);
                    sb.Append(" hundred and ");
                }

                if (digits[2] > 1)
                {
                    sb.Append(tens2[digits[2] - 1]);
                    sb.Append(" ");
                    sb.Append(unit[digits[3] - 1]);
                }
                else if (digits[2] == 1)
                {
                    sb.Append(tens[digits[3]]);
                }
                else
                {
                    sb.Append(unit[digits[3] - 1]);
                }
            }

            Console.WriteLine(sb.ToString());
        }
        else
        {
            Console.WriteLine("Only four digit number is supported in trial version of this program !!!");
        }

        Console.ReadKey();
    }

Now it supports any value gracefully. 121212, 1, 0000, 0001, 0011, 0101, 1001, etc

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.