This tag is for questions about the practice of code review and code walkthroughs.
2
votes
5answers
191 views
Who is responsible for fixing failed SQL code reviews? [closed]
As a DBA, most SQL is submitted to my team for review. We do not have a SQL developer, so the code is frequently very, very inefficient.
Our current process is:
SQL is submitted for review right ...
9
votes
3answers
416 views
What to do when your colleagues don't value code maintainability [duplicate]
I've been working in the same software development department for a few years now. In that time, the average stay of a developer has been 6-9 months. A handful have been around for over 2 years, but ...
2
votes
3answers
281 views
What feedback is or is not appropriate for a code review? [duplicate]
I am interested in hearing some guidelines as to what feedback is or is not appropriate for a code review. My team has a very unstructured review process and I am trying to suggest some ways to ...
0
votes
0answers
18 views
Selection sort review. Does it look good? [migrated]
I always wanted to ask this but couldn't for some reason.
I had written this chunk of code about 3 months ago when one of my teacher explained what selection sort was using flow chart. I had a basic ...
0
votes
2answers
128 views
Code review practice in medium team [closed]
I'm looking for a way to organize code review process.
My inputs:
4-5 members in the team;
SVN/IntelliJ IDEA Community Edition.
Solution criteria:
Should support human review with ...
-4
votes
1answer
70 views
Check Javascript coding practice and overall performance [closed]
I have a Edit/Details form which has 4 user related fields. On click of Save, I save the edited fields to local storage (if supported) and display the same values in the Details view.
Below is the ...
2
votes
0answers
31 views
How to associate a new/modified changeset with an existing review in VisualStudio 2012
I'm trying out the new Code Review tool in Visual Studio 2012. Which seems okay for the most part, but I've hit a wall in regards to when changes are required.
How should this be handled in a code ...
0
votes
4answers
168 views
How to count condition coverage
I am wondering, What would be the correct condition coverage test cases for the following condition:
if(A && E && (B || C || D))
Considering short circuiting, what cases would I ...
4
votes
2answers
236 views
code review with git-flow and github
With regular git and github I can do a code review by simply creating a pull request of the feature branch I'm working on to the master branch. How would I do code reviews with git-flow? With workflow ...
31
votes
10answers
2k views
Should Junior Programmers be involved as code reviewers in the projects of Senior Programmers?
One of my team members (a junior programmer) has good programming skills. I believe at Code reviews (with an emphasis on learning, not pointing out mistakes).
Should junior programmers be involved as ...
-1
votes
3answers
138 views
Programming task to test for focus on maintainability [closed]
I am looking for a programming task, which shows whether the coder has maintainability in mind while programming. I imagine giving a task to fix a bug in a method. It should be clear to the programmer ...
5
votes
1answer
244 views
What would Business Intelligence (BI) developers look for in code reviews?
Let me preface this with saying I am not a Business Intelligence (BI) developer. I'm a .NET developer, and I have only a vague notion of what BI is, and encompasses.
I've been an evangelist for a ...
6
votes
4answers
299 views
How do you deal with discovering bad and false code in your team? [duplicate]
Every year in january we process a big task with our system. While the performance during the task was above average the maintaince follow up is currently having a lot of trouble with jobs running too ...
59
votes
19answers
10k views
How important is it to reduce the number of lines in code?
I am a Software developer who works on J2SE (core java).
Often during our code reviews we are asked to reduce the number of lines in our code.
It's not about removing redundant code, it's about ...
6
votes
3answers
160 views
Branches/decision count in an example
Having read SO, just found this question:
if (x > y)
print (x)
else if (x < y)
print (y)
else
print (x,y)
How many branches and decisions are there? It mentiones there should ...
