Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I am having a problem with this simple sql query:

<?php 
require_once('../../Connections/tohoshows.php'); 

$show ='gothaf';

mysql_select_db($database_tohoshows, $tohoshows);
$query_getShows = "SELECT * FROM toho_shows WHERE toho_shows.show =' ". $show. " '";
$getShows = mysql_query($query_getShows, $tohoshows) or die(mysql_error());
$row_getShows = mysql_fetch_assoc($getShows);
$totalRows_getShows = mysql_num_rows($getShows);

mysql_free_result($getShows);
?>

When I use the string directly in the WHERE clause like this

 $query_getShows = "SELECT * FROM toho_shows WHERE toho_shows.show ='gothaf'";

I get a result. When I use the variable instead, I get no data! I am a novice and I can't figure out what am I doing wrong. Any help would be appreciated. Thank you!

share|improve this question
1  
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. – FreshPrinceOfSO Mar 28 at 14:39

2 Answers

up vote 5 down vote accepted

you getting no date because you have extra space betwee the quotes,

$query_getShows = "SELECT * FROM toho_shows WHERE toho_shows.show =' ". $show. " '";
                                                                    ^ HERE      ^

which will then be parsed into

SELECT * FROM toho_shows WHERE toho_shows.show =' gothaf '

remove it and it will work

$query_getShows = "SELECT * FROM toho_shows WHERE toho_shows.show ='". $show. "'";

As a sidenote, the query is vulnerable with SQL Injection if the value(s) of the variables came from the outside. Please take a look at the article below to learn how to prevent from it. By using PreparedStatements you can get rid of using single quotes around values.

share|improve this answer
Thank you for your answer! I have also tried with no spaces in between, but I still get no data. – Akis Wma Asimakopoulos Mar 28 at 14:33
post the result of this echo $query_getShows; – 491243 Mar 28 at 14:34
You shouldn't even consider using this approach anyway, @Akis, it's really easy to use prepared statements and yet it is system critical. – Jonast92 Mar 28 at 14:35
1  
OK guys! This thing actually works, I don't know why dreamweaver doesn't return any data on the sql statement test! Thanks everybody! @Jonast92 I will consider the prepared statements as you said! Thanks! – Akis Wma Asimakopoulos Mar 28 at 15:00
2  
Thank you!! @JW – Akis Wma Asimakopoulos Mar 28 at 15:04
show 5 more comments
up vote 0 down vote

when you use " , you can write your code like this :

$query_getShows = "SELECT * FROM toho_shows WHERE toho_shows.show ='$show'";

so php parse the string and set variable value in the string text, it's easier and Less you're wrong..

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.