Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

So I am updating my mysql database using php. Below is the end of the UPDATE, and if I have a string instead of echo $row[embedcode]"); it works fine, and this echo sets data on the page just fine retrieving the right value, but within this UPDATE it doesn't work.

...WHERE `embedcode` = echo $row[embedcode]");

I have tried using ". ." around it and adding its own php tag around it but I'm not sure what needs to be done.

share|improve this question
Why are you trying to embed an echo inside an SQL statement? – andrewsi 9 hours ago

6 Answers

up vote 1 down vote accepted 
" ... WHERE `embedcode=` '" .$row[embedcode]. "';");
share|improve this answer
This is actually the only one that worked, but now I'm getting the database updated every time the page is loaded and not just when the button is clicked. I'm simply attempting to increment a value by 1 whenever a button is clicked. I assumed this could be done by doing the following: <a href="<?php echo $uv ?>">test</a> with uv being the update query. Because it's in the anchor tag, I thought it would only happen when clicked. – dudledok 4 hours ago
well, that could not work, since whatever you pass to the href attribute, it will be handled as a string of an url, either relative or a full url. so if you really want to use the a tag as a button, than you should do something like this in the php: $uv=$_GET['uv'] and the html part should look like this: <a href="/uv=<?=($uv+1);?>">button<a> but this will cause the page to reload every time you click on the button and i think -without seeing the whole code- that JS would be better to use... – ppseprus 2 hours ago
well, im not sure how you want it without context, but if you put the mysql updating part into a function and you only fire it when the $_GET['uv'] is set: if(isset($_GET['uv'])) { .. UPDATE .. } than that could be a solution. post a bit more and then i can help more.. – ppseprus 2 hours ago
this way, the thing inside the if only run when the url has the uv variable in it: http://yoururl.com/?uv=somenumber – ppseprus 2 hours ago
up vote 6 down vote

Just use this:

...WHERE `embedcode` = " . $row[embedcode]);

There is no need for echo.

As a side note, you should probably parameterize or at least sanitize any strings that go into a MySQL query to prevent SQL injection and other bad things.

share|improve this answer
up vote 0 down vote

WHEREembedcode= . $row[embedcode]); will set the value.

There is not need for echo inside the sql statement. echo is used for displaying something from php to the webbrowser.

share|improve this answer
up vote 0 down vote

You don't use echo, perhaps it should be:

...WHERE `embedcode=` . $row[embedcode]");

Not that if $row[embedcode] is a string you have to put quotes around it.

share|improve this answer
up vote 0 down vote

Let say for example...

("UPDATE `tblProfile` SET `profilename` = 'abc' WHERE `embedcode` = '".$row['embedcode']."'");
share|improve this answer
up vote 0 down vote

to prevent SQL injection, you can pass that value as a parameter if you are using PDO or MySQLi.

For example,

$stmt = $dbConnection->prepare('...WHERE `embedcode` = :embedcode');
$stmt->execute(array(':embedcode' => $row[embedcode]));

See this for details.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.