Explore our sites

Stack Exchange
tour help careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote -1 down vote favorite

I am fairly new to java and i'm trying to write this simple program to calculate the cost of admission for single and multiple employees.

this is the error message im getting about the operators in my conditional statements: 

incomparable types: int and java.lang.String

Code

import java.text.*;
import java.util.Scanner;

class IMC {
    public static void main(String[] args) {

    int numEmployees = 0;
    double costPerAttendee = 0.00;
    double admissionPrice = 0.00;

    Scanner keyboard = new Scanner (System.in);

    System.out.print("Enter amount of employees attending: ");
    numEmployees = keyboard.nextInt();

    System.out.print("Have any employees attended previously? ");
    employeeDiscount = keyboard.nextInt();

    if (numEmployees == "1")    { 
            admissionPrice = 695.00;
    } else if (numEmployees == "2" || "3" || "4") { 
            admissionPrice = 545.00;
    } else if (numEmployees >= "5" || "6" || "7" || "8") { 
            admissionPrice = 480.00;
    } else if (numEmployees >= "9") { 
            admissionPrice = 395.00;
    }

    System.out.println("The cost per attendee is: " + admissionPrice );

   }
}
share|improve this question
add comment

closed as too localized by seh, Sylvain Defresne, Mario, Beerlington, Code-Guru Feb 3 '13 at 23:21

This question is unlikely to help any future visitors; it is only relevant to a small geographic area, a specific moment in time, or an extraordinarily narrow situation that is not generally applicable to the worldwide audience of the internet. For help making this question more broadly applicable, visit the help center.If this question can be reworded to fit the rules in the help center, please edit the question.

4 Answers

up vote 1 down vote 
numEmployees == 1

instead of 

numEmployees == "1"

numEmployees is int and "1" is string . So you are getting int and java.lang.String error message.

public static void main(String[] args) {

    int numEmployees = 0;
    double costPerAttendee = 0.00;
    double admissionPrice = 0.00;
    int employeeDiscount = 0;
    Scanner keyboard = new Scanner(System.in);

    System.out.print("Enter amount of employees attending: ");
    numEmployees = keyboard.nextInt();

    System.out.print("Have any employees attended previously? ");
    employeeDiscount = keyboard.nextInt();

    if (numEmployees == 1) {
        admissionPrice = 695.00;
    } else if (numEmployees == 2 || numEmployees == 3 || numEmployees == 4) {
        admissionPrice = 545.00;
    } else if (numEmployees == 5 || numEmployees == 6 || numEmployees == 7
            || numEmployees == 8) {
        admissionPrice = 480.00;
    } else if (numEmployees >= 9) {
        admissionPrice = 395.00;
    }

    System.out.println("The cost per attendee is: " + admissionPrice);
}

I edited your code try this.

share|improve this answer
1  
thanks for answering so fast. I've tried that and it doesn't seem to affect anything. I'm still getting the same error message –  montenegroxnj Feb 3 '13 at 15:46
 
@montenegroxnj No you're not, or you didn't fix all of them. –  Dave Newton Feb 3 '13 at 15:48
 
@montenegroxnj What is input for "Have any employees attended previously?" –  Achintya Jha Feb 3 '13 at 16:04
1  
@AchintyaJha Oops, forgot to actually post my comment about the broken logic, but you fixed it anyway :) –  Dave Newton Feb 3 '13 at 16:13
 
@DaveNewton About what? –  Achintya Jha Feb 3 '13 at 16:16
show 2 more comments
up vote 0 down vote

numEmployees is not String. You shoud use something like

if (numEmployees == 1) { 
  //A
} else if (numEmployees < 5) { 
  //B
} else if (numEmployees < 9) { 
  //C
} else {
  //D
}
share|improve this answer
 
thanks for your input –  montenegroxnj Feb 3 '13 at 16:00
add comment
up vote 0 down vote

Two issues there:

  1. numEmployees is an int, not a String, so you don't want the quotes:

    if (numEmployees == 1)

  2. Later, where you're doing this (I removed the quotes):

    else if (numEmployees == 2 || 3 || 4)

    you want

    else if (numEmployees == 2 || numEmployees == 3 || numEmployees == 4)

    There is no "equals any of the items on this list" operator, per se, you have to say what you're comparing on both sides of the operator each time, and use ranges where possible, for instance:

    else if (numEmployees >= 2 && numEmployees <= 4)

    (And since it's an else on if (numEmployees == 1) arguably you could leave off the first part of that, if you know it won't be 0 or negative.)

    You might also look at the switch statement.

share|improve this answer
 
Or <=/>= comparisons. –  Dave Newton Feb 3 '13 at 15:49
 
@DaveNewton: Indeed. –  T.J. Crowder Feb 3 '13 at 15:53
 
Thank you for answering so quick. i've updated my code and this is what i'm getting...... operator || cannot be applied to boolean,int } else if (numEmployees >= 5 || 6 || 7 || 8){ admissionPrice = 480.00; ...... numEmployees is an int.. should I be using a different data type? –  montenegroxnj Feb 3 '13 at 15:56
 
@montenegroxnj: Yes, you have to apply the logic in my point #2 to all of your code, not just the one line I gave as an example. –  T.J. Crowder Feb 3 '13 at 15:59
 
@T.J.Crowder OH, now I get it. Thanks a lot sir –  montenegroxnj Feb 3 '13 at 16:50
add comment
up vote 0 down vote

I have tested this one and works correctly

import java.text.*;
import java.util.Scanner;

class Test {
public static void main(String[] args) {

int numEmployees = 0;
double costPerAttendee = 0.00;
double admissionPrice = 0.00;

Scanner keyboard = new Scanner (System.in);

System.out.print("Enter amount of employees attending: ");
numEmployees = keyboard.nextInt();

System.out.print("Have any employees attended previously? ");
int employeeDiscount = keyboard.nextInt();

if (numEmployees == 1)    { admissionPrice = 695.00;


} else if (numEmployees == 2 ||numEmployees ==  3 ||numEmployees ==  4) { admissionPrice    = 545.00;


} else if (numEmployees >= 5 ||numEmployees >= 6 ||numEmployees >= 7 ||numEmployees >=     8){ admissionPrice = 480.00;


} else if (numEmployees >= 9) { admissionPrice = 395.00;

}

    System.out.println("The cost per attendee is: " + admissionPrice );

   }
}
share|improve this answer
 
No it doesn't; 9 >= 5. –  Dave Newton Feb 3 '13 at 16:04
 
I mean It has no errors But I dont know what is your tests , As code has no errors and works correctly any other issues depend on your inputs –  rabar kareem Feb 3 '13 at 16:28
 
It doesn't matter what my tests are: by visual inspection it's clear that the if conditions are incorrect; they should be == except for the last one. –  Dave Newton Feb 3 '13 at 16:36
 
@rabar this really helped. thanks so much –  montenegroxnj Feb 3 '13 at 16:50
add comment

Not the answer you're looking for? Browse other questions tagged or ask your own question.