PHP if, else, and return true/false

Question

Just wondering if my

else {return false;}

statements are superfluous... do I just need one return true; here?

function has_access() {
    if ( is_user_logged_in() ) {
        $role = get_current_user_role();
        $admins = array(
            'Administrator',
            'Agent',
            'Contributor',
        );

        if (in_array($role, $admins)) {
            return true;
        } else {
            return false;
        }
    } else {
        return false;
    }
}

palacsint · Accepted Answer · 2012-05-03 21:53:44Z

I'd replace the conditions with guard clauses. (Flattening Arrow Code)

function has_access() {
    if ( !is_user_logged_in() ) {
        return false;
    }
    $role = get_current_user_role();
    $admins = array(
        'Administrator',
        'Agent',
        'Contributor',
    );

    if (in_array($role, $admins)) {
        return true;
    }
    return false;
}

Kao Vang · Answer 2 · 2012-05-03 23:27:18Z

up vote 9 down vote

function has_access() {
    if (is_user_logged_in()) {
        $admins = array(
            'Administrator',
            'Agent',
            'Contributor',
        );
        return in_array(get_current_user_role(), $admins);
    }
   return false;
}

answered May 3 '12 at 23:27

Kao Vang
20113

1

Both answers, yours and palacsint's, are correct. But I like the way you did yours better :) It's much cleaner and keeps with the "sentence" structure this code has attempted to implement +1 – mseancole May 4 '12 at 15:31

watain · Answer 3 · 2012-06-15 20:36:43Z

up vote 4 down vote

How about:

function has_access() {
    if (!is_user_logged_in())
        return false;

    return in_array(get_current_user_role(), array(
        'Administrator',
        'Agent',
        'Contributor'
    ));
}

answered Jun 15 '12 at 20:36

watain
1411

asked	1 year ago
viewed	352 times
active	11 months ago

PHP if, else, and return true/false

3 Answers

Your Answer

Not the answer you're looking for? Browse other questions tagged php clean-code conditions or ask your own question.

Community Bulletin

PHP if, else, and return true/false

3 Answers

Your Answer

Sign up or log in

Post as a guest

Not the answer you're looking for? Browse other questions tagged php clean-code conditions or ask your own question.

Community Bulletin

Related