Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

i'm trying to insert a POST array consisting in 8 fields to a mysql table of 8 columns. But i'm getting this error when submitting the form:

Error: Column count doesn't match value count at row 1

When i search this error says the data passed doesn't fit in the column count of the database table, but the table has 8 columns. What i'm doing wrong?.

Here's my code:

<html>
<body>
<form action="" method="post">

Nombre: <input type="text" name="data[]">
Apellido: <input type="text" name="data[]"></br>
Direccion: <input type="text" name="data[]"></br>
Telefono: <input type="text" name="data[]">
Telefono 2: <input type="text" name="data[]"></br>
Email: <input type="text" name="data[]"></br>
Edad: <input type="text" name="data[]"></br>
Foto: <input type="text" name="data[]"> 
<input type="submit">

</form>

<?php

$con=mysql_connect("localhost","root","");

if (!$con){  die('Could not connect: ' . mysql_error()); }


mysql_select_db("ag_online", $con);

foreach($_POST['data'] as $d ){
    $sql = "INSERT INTO `contacts` VALUES ('', '".$d."');";
    mysql_query( $sql ); 
}


if (!mysql_query($sql,$con))
{
die('Error: ' . mysql_error());
}   
echo "1 record added";

mysql_close($con);

?>

</body>
</html>
share|improve this question

2 Answers

up vote 1 down vote

If the table has 8 columns, you cannot use:

$sql = "INSERT INTO `contacts` VALUES ('', '".$d."');";

directly.

You have to specify which columns you are inserting:

$sql = "INSERT INTO `contacts` (col1, col2) VALUES ('', '".$d."');";

Update
When you using

foreach($_POST['data'] as $d ){
    $sql = "INSERT INTO `contacts` VALUES ('', '".$d."');";
    mysql_query( $sql ); 
}

is the same as using

foreach($_POST['data'] as $d ){
    $sql = "INSERT INTO `contacts` (Nombre, Apellido, Direccion, Telefono, Telefono2, Email, Edad, Foto)  VALUES ('', '".$d."');";
    mysql_query( $sql ); 
}

as you say in the comments.

However, as you are looping on $_POST['data'], it will come to something like:

first loop:

    $sql = "INSERT INTO `contacts` (Nombre, Apellido, Direccion, Telefono, Telefono2, Email, Edad, Foto)  VALUES ('', 'FIRST_VALUE');";

first loop:

    $sql = "INSERT INTO `contacts` (Nombre, Apellido, Direccion, Telefono, Telefono2, Email, Edad, Foto)  VALUES ('', 'SECOND_VALUE');";

that is, you will try to insert 2 values after saying you will give 8.

You can use the following to populate a variable $info and then do an unique insert:

$info=implode(",", $_POST['data']);
$info="\"".implode("\",\"", $_POST['data'])."\""; //<--- updated answer, to have all items "wrapped"

and then

$sql = "INSERT INTO `contacts` (Nombre, Apellido, Direccion, Telefono, Telefono2, Email, Edad, Foto)  VALUES ('', $info);";
share|improve this answer
I've tried: foreach($_POST['datos'] as $d ){ $sql = "INSERT INTO contactos (Nombre, Apellido, Direccion, Telefono, Telefono2, Email, Edad, Foto) VALUES ('', '".$d."');"; mysql_query( $sql ); } – Guille Mar 31 at 18:42
but i get the same error... – Guille Mar 31 at 18:43
Can you show a print_r($_POST['datos']); this way we can see what can be happening – zipser Mar 31 at 18:46
1  
how are you going to insert nombre, apellida, direccion, telefono, etc.. with values ('', '', 'id'), it DOES NOT match again. As @zipser said you have to explicively tell which column you are going to insert in. If you are inserting 2 values, then only 2 columns – Royal Bg Mar 31 at 18:48
sure: Array ( [0] => Name [1] => LastName [2] => Address [3] => 123 [4] => 456 [5] => [email protected] [6] => 25 [7] => photo ) – Guille Mar 31 at 18:56
show 23 more comments
up vote 0 down vote

If you are trying to have each one in column, then you might want to consider this

$sql = "INSERT INTO `contacts` VALUES ('";
foreach($_POST['data'] as $d ){
 $sql .= $d."','";
}
 $sql = substr_replace($sql, "", -2);
 $sql .= ");";
 mysql_query( $sql );
share|improve this answer
1  
It will give trailing comma + apostrophe which will generate error, You need removal of last comma + apostrophe outside loop. – kuldeep.kamboj Mar 31 at 18:38
i'm getting this error with that code: Parse error: syntax error, unexpected T_FOREACH in C:\wamp\www\ABM 1\index.php on line 29 – Guille Mar 31 at 18:52
I updated the script to delete the last comma, :) – devBinnooh Mar 31 at 18:54
1  
Add semi colon after first line – kuldeep.kamboj Mar 31 at 18:54
done :) Thanks kuldeep.Kamboj – devBinnooh Mar 31 at 18:55

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.