up vote -2 down vote favorite

I am trying to delete records from my table but unable to do so. I have window form with Insert, Update, Delete and Save button. I can insert data but I can't delete specific or any records from that table. Below is my code.

Whenever I click 'delete' button I get ("Error while deleting record on table..." & ex.Message, "Delete Records") msgbox only.

Am I missing something? Please advise. Any help would be great. Thank you!

Private Sub Deletebtn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Deletebtn.Click

    Dim con As New SqlConnection
    Dim cmd As New SqlCommand
    Try
        con.ConnectionString = "Server=USRAG-L-0067215\SQLEXPRESS;Database=Alamo Products_Design Data;Trusted_Connection=True"
        con.Open()
        cmd.Connection = con
        cmd.CommandText = "Delete From Design_Parameters where DesignID= ? "
        cmd.ExecuteNonQuery()
        If MessageBox.Show("Do you really want to Delete this Record?", "Delete", MessageBoxButtons.YesNo, MessageBoxIcon.Warning) = DialogResult.No Then

            MsgBox("Operation Cancelled")

            Exit Sub

        End If
    Catch ex As Exception
        MessageBox.Show("Error while deleting record on table..." & ex.Message, "Delete Records")

    Finally

        con.Close()
    End Try
End Sub

End Class

share|improve this question
DesignID= ? will not work, did you mean DesignID='?' – Neolisk Dec 10 '12 at 21:26
You're using a parameterized query, but have not assigned a value to the parameter. If that's not the problem, you'll need to post the actual exception you're receiving. – alroc Dec 10 '12 at 21:27
Also, there is no point in asking about record deletion if you already did it. Your code will show Operation cancelled when it really wasn't. – Neolisk Dec 10 '12 at 21:27
@alroc: parameters in SQL are denoted with @, not ?. – Neolisk Dec 10 '12 at 21:31
@Neolisk..Thx for your reply. Even If I put '?', It gives me return value of designID with '?' correct? What do you suggest? – Joy1979 Dec 10 '12 at 21:34
show 4 more comments
feedback

closed as not a real question by Neolisk, bensiu, Chris Gerken, Dante is not a Geek, Ram kiran Dec 11 '12 at 3:07

It's difficult to tell what is being asked here. This question is ambiguous, vague, incomplete, overly broad, or rhetorical and cannot be reasonably answered in its current form. For help clarifying this question so that it can be reopened, see the FAQ.

1 Answer

up vote 0 down vote

you need to add parameter for DesignID

Dim con As New SqlConnection
    Dim cmd As New SqlCommand
    Try
        con.ConnectionString = "Server=USRAG-L-0067215\SQLEXPRESS;Database=Alamo Products_Design Data;Trusted_Connection=True"
        con.Open()
        cmd.Connection = con
        cmd.CommandText = "Delete From Design_Parameters where DesignID= @DesignID"
    cmd.Parameters.Add(New SqlParameter("@DesignID", yourvaluehere))
        cmd.ExecuteNonQuery()
        If MessageBox.Show("Do you really want to Delete this Record?", "Delete", MessageBoxButtons.YesNo, MessageBoxIcon.Warning) = DialogResult.No Then

            MsgBox("Operation Cancelled")

            Exit Sub

        End If
    Catch ex As Exception
        MessageBox.Show("Error while deleting record on table..." & ex.Message, "Delete Records")

    Finally

        con.Close()
    End Try
share|improve this answer
Thx for your help and code, One question....What value should I put in "yourvaluehere"? cmd.Parameters.Add(New SqlParameter("@DesignID", yourvaluehere)) – Joy1979 Dec 10 '12 at 21:42
IT should be the value of the primary key "DesignID" of the record you want to delete. Please put the statement "cmd.ExecuteNonQuery()" in the "else" part of the condition (MessageBox.Show): otherwise, you will delete the record, ask the question, but be unable to roll back. Serge – Serge Bollaerts Dec 10 '12 at 23:42
feedback

Not the answer you're looking for? Browse other questions tagged or ask your own question.