Refactor ruby each-code

Question

def users_list  
  html = ''  
  self.users.each do |user|  
    html << user.link_avatar_tag  
  end  
  html.html_safe  
end

I feel that it is possible to write shorter.

Is it possible get rid of the temporary variable(html)?

What class is user? html_safe is no standard method for String - What gems are you using? Or in short: Can you provide a MWE? And to answer: It looks ok for me.
Main topic of my question: Is it possible get rid of the temporary variable(html)?
This is TaskDecorator. Task has_and_belongs_to_many :users github.com/drapergem/draper

tokland · Accepted Answer · 2013-01-15 08:26:10Z

up vote 5 down vote accepted

You should use map (don't use each to accumulate. Check this page about functional programming):

def users_list  
  users.map(&:link_avatar_get).join.html_safe
end

edited Jan 15 at 8:26

answered Jan 7 at 16:36

tokland
3,015410

1

I change code a bit & that works: self.users.map(&:link_avatar_tag).join.html_safe – Fant Geass Jan 7 at 16:47

mmm, yes, you are right, here safe_join is not necessary, edited. – tokland Jan 7 at 17:05

1 Answer