Return Javascript value inside Html from another JS

Question

I need ur help i know this is a silly question but am not able to solve it ...sorrry :(

I have one javascript file welcome.js in that i have

    function alert()
    {
    return 10;
    }

I have another html file welcome.html in which am invoking the welcome.js file

    <html xmlns="http://www.w3.org/1999/xhtml">
    <head>
    <meta http-equiv="content-type" content="text/html; charset=utf-8" />

    <script type="text/javascript src="welcome.js"></script>
    <script>
    function myFunction()
    {
     var x = alert();
    return x;
    }
    </script>
    </head>

    <body>
     <input type="button" onclick="myFunction();" value="Show alert box">

I keep on getting this error in mozilla console

Timestamp: 5/28/2013 9:56:47 PM Error: NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIDOMWindow.alert]

@Niklas good catch! (deleted my comment as it was misleading) — acdcjunior, Commented May 28, 2013 at 16:46

Niklas · Accepted Answer · 2013-05-28 16:40:11Z

5

Your javascript (welcome.js) isn't getting loaded do to the syntax error in your script tag. You are missing the " quote after text/javascript.

The alert(); is calling window.alert() which requires an argument to be passed in Firefox (doesn't for example in Chrome). As your own welcome.js never gets loaded (due to the syntax error), it never ends up rewriting the global alert() function.

answered May 28, 2013 at 16:40

Niklas

30k5 gold badges54 silver badges74 bronze badges

Add a comment |

Michael Aguilar · Accepted Answer · 2013-05-28 18:51:28Z

3

alert function name shouldn't be overriden, because in that case if you use

alert(something)

you will call to your new function and not to the dialog function

You have 2 options:

put another name to your function alert
when you need to call to dialog function use window.alert(something) to differentiate

edited May 28, 2013 at 18:51

answered May 28, 2013 at 16:38

Michael Aguilar

8559 silver badges16 bronze badges

It isn't reserved, it just never is getting overwritten.
– Niklas
Commented May 28, 2013 at 16:40
@Niklas this is a best replication of the problem, and doesnt work: jsfiddle.net/G5xKB/1
– Michael Aguilar
Commented May 28, 2013 at 16:51

Add a comment |

Mehdi Karamosly · Accepted Answer · 2013-05-28 16:44:06Z

0

You can not override window.alert() function, try the below:

 function test()
    {
    return 10;
    }

Then in you html use test()

<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8" />

<script type="text/javascript src="welcome.js"></script>
<script>
function myFunction()
{
 var x = test();
return x;
}
</script>
</head>

<body>
 <input type="button" onclick="myFunction();" value="Show alert box">

answered May 28, 2013 at 16:44

Mehdi Karamosly

5,4382 gold badges33 silver badges50 bronze badges

Add a comment |

Collectives™ on Stack Overflow

Return Javascript value inside Html from another JS

3 Answers 3

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Your Answer

Sign up or log in

Post as a guest

Related