Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
using System;
using System.Collections;
using System.Configuration;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.HtmlControls;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Xml.Linq;
using System.Data.SqlClient;

public partial class requisitionform : System.Web.UI.Page
{
    SqlConnection myConnection = new SqlConnection("Data Source=saad-pc;Initial Catalog=ovms;Integrated Security=True");
    SqlCommand cmd = new SqlCommand();
    SqlDataReader dr;
        protected void page_load(object sender, EventArgs e)
        {

            //if (!IsPostBack)
            //{
            //    if (Session["username"] != null)
            //        Response.Redirect("Default.aspx");
            //    else Response.AddHeader("Cache-Control", "no-cache, no-store, max-age=0, must-revalidate");
            //    {
            //        Response.ClearHeaders();

            //        Response.AddHeader("Pragma", "no-cache");
            //    }
            //}


        }

        protected void BtnSubmit_click(object sender, EventArgs e)
        {
            if (rdb1.Checked == true)
            {
                cmd.Connection = myConnection;
                //myConnection.Open();
                cmd.CommandText = "INSERT INTO tblRequest (@employeeID, @requestType, @source, @destination, @requestFromDateTime, @requestToDateTime, @vehicleID, @requestDescription )";
                cmd.Parameters.Clear();
                cmd.Parameters.AddWithValue("@employeeID", TextBox1.Text);
                cmd.Parameters.AddWithValue("@requestType", rdb1.Value);
                cmd.Parameters.AddWithValue("@source", TextBox3.Text);
                cmd.Parameters.AddWithValue("@destination", TextBox4.Text);
                cmd.Parameters.AddWithValue("@requestFromDateTime", datetime1.Text);
                cmd.Parameters.AddWithValue("@requestToDateTime", datetime1.Text);
                cmd.Parameters.AddWithValue("@vehicleID", DropDownList1.Text);
                cmd.Parameters.AddWithValue("@requestDescription", TextB.Text);
                if (myConnection.State == ConnectionState.Closed)
                {

                    myConnection.Open();

                    cmd.ExecuteNonQuery();


                    myConnection.Close();
                    Response.Write("<script language=javascript>alert('data entered.')</script>");

                    //= "Data entered successfully!!!";

                    clear();
                    //cmd.ExecuteNonQuery();
                    //myConnection.Close();
                }
                }
            else
            {
                cmd.Connection = myConnection;
                //myConnection.Open();
                cmd.CommandText = "INSERT INTO tblRequest (@employeeID, @requestType, @source, @destination, @requestFromDateTime, @requestToDateTime, @vehicleID, @requestDescription )";
                cmd.Parameters.Clear();
                cmd.Parameters.AddWithValue("@employeeID", TextBox1.Text);
                cmd.Parameters.AddWithValue("@requestType", rdb2.Value);
                cmd.Parameters.AddWithValue("@source", TextBox3.Text);
                cmd.Parameters.AddWithValue("@destination", TextBox4.Text);
                cmd.Parameters.AddWithValue("@requestFromDateTime", datetime1.Text);
                cmd.Parameters.AddWithValue("@requestToDateTime", datetime1.Text);
                cmd.Parameters.AddWithValue("@vehicleID", DropDownList1.Text);
                cmd.Parameters.AddWithValue("@requestDescription", TextB.Text);
                if (myConnection.State == ConnectionState.Closed)
                {
                    myConnection.Open();

                    cmd.ExecuteNonQuery();

                    myConnection.Close();
                    Response.Write("<script language=javascript>alert('data entered.')</script>");

                    //= "Data entered successfully!!!";

                    clear();
                }
                }
        }

        private void clear()
        {
            throw new NotImplementedException();
        }


}

The data is not inserted, and an 'executenonquery' exception occurs. I don't know what the error is. Kindly review the code and suggest better technique.

share|improve this question
Your insert statement is incorrect – archil 16 mins ago
2  
Specifically it is missing VALUES and should be INSERT INTO tblRequest VALUES (... – Martin Smith 15 mins ago

1 Answer

protected void BtnSubmit_click(object sender, EventArgs e)
    {
        if (rdb1.Checked == true)
        {
            cmd.Connection = myConnection;
            //myConnection.Open();
            cmd.CommandText = "INSERT INTO tblRequest VALUES (@employeeID, @requestType, @source, @destination, @requestFromDateTime, @requestToDateTime, @vehicleID, @requestDescription )";
            cmd.Parameters.Clear();
            cmd.Parameters.AddWithValue("@employeeID", TextBox1.Text);
            cmd.Parameters.AddWithValue("@requestType", rdb1.Value);
            cmd.Parameters.AddWithValue("@source", TextBox3.Text);
            cmd.Parameters.AddWithValue("@destination", TextBox4.Text);
            cmd.Parameters.AddWithValue("@requestFromDateTime", datetime1.Text);
            cmd.Parameters.AddWithValue("@requestToDateTime", datetime1.Text);
            cmd.Parameters.AddWithValue("@vehicleID", DropDownList1.Text);
            cmd.Parameters.AddWithValue("@requestDescription", TextB.Text);
            if (myConnection.State == ConnectionState.Closed)
            {

                myConnection.Open();

                cmd.ExecuteNonQuery();


                myConnection.Close();
                Response.Write("<script language=javascript>alert('data entered.')</script>");

                //= "Data entered successfully!!!";

                clear();
                //cmd.ExecuteNonQuery();
                //myConnection.Close();
            }
            }
        else
        {
            cmd.Connection = myConnection;
            //myConnection.Open();
            cmd.CommandText = "INSERT INTO tblRequest VALUES  (@employeeID, @requestType, @source, @destination, @requestFromDateTime, @requestToDateTime, @vehicleID, @requestDescription )";
            cmd.Parameters.Clear();
            cmd.Parameters.AddWithValue("@employeeID", TextBox1.Text);
            cmd.Parameters.AddWithValue("@requestType", rdb2.Value);
            cmd.Parameters.AddWithValue("@source", TextBox3.Text);
            cmd.Parameters.AddWithValue("@destination", TextBox4.Text);
            cmd.Parameters.AddWithValue("@requestFromDateTime", datetime1.Text);
            cmd.Parameters.AddWithValue("@requestToDateTime", datetime1.Text);
            cmd.Parameters.AddWithValue("@vehicleID", DropDownList1.Text);
            cmd.Parameters.AddWithValue("@requestDescription", TextB.Text);
            if (myConnection.State == ConnectionState.Closed)
            {
                myConnection.Open();

                cmd.ExecuteNonQuery();

                myConnection.Close();
                Response.Write("<script language=javascript>alert('data entered.')</script>");

                //= "Data entered successfully!!!";

                clear();
            }
            }
    }
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.