How to display ObserveableCollection<T> in ListBox

Question

I can't bind to my ObservableCollection<T> within my ListBox.

I am using MVVM, WPF.

The binding for the page works. My understanding is, the Grid (not shown in code) is bound to my DataContext, which is my ViewModel. Therefore, my ListBox can bind to my object called Folders via the Itemssource. My Folders object is very simple, it is literally

private ObservableCollection<Folders> _folders;
public ObservableCollection<Folders> Folders 
{
get { return _folders; }
set
  {
      if (value == _folders)
      return;

      _folders = value;
      OnPropertyChanged("Folders");
   }
}

and my Folders model is

public class Folders
{
    public string SourceFolder { get; set; }
    public string DestinationFolder { get; set; }
}

and lastly, my XAML

    <ListBox Grid.RowSpan="2" ItemsSource="{Binding Folders, UpdateSourceTrigger=PropertyChanged}" Grid.Row="1" SelectedItem="{Binding SelectedFolderItem}" IsSynchronizedWithCurrentItem="True">
        <ListBox.ItemTemplate>
            <DataTemplate>
                <StackPanel Orientation="Horizontal" DataContext="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type ListBox}, AncestorLevel=1}, Path=DataContext}">
                    <StackPanel>
                        <TextBlock Text="{Binding SourceFolder}" />
                        <TextBlock Text="{Binding DestinationFolder}" />
                        <Button Content="Edit" Command="{Binding EditCommand}" CommandParameter="{Binding SelectedListItem}"/>
                    </StackPanel>
                </StackPanel>
            </DataTemplate>
        </ListBox.ItemTemplate>
    </ListBox>

The button binds/executes, but the 2 textblocks do not. I have also tried

 <TextBlock Text="{Binding Folders.SourceFolder}" />
 <TextBlock Text="{Binding Folders.DestinationFolder}" />

but it is the same issue. The content is not displayed (not binding) because if I add a watch on my ViewModel, I can see the values are as they should be.

If it helps, if I update my code to

 <TextBlock Text="{Binding SelectedFolderItem.SourceFolder}" />
 <TextBlock Text="{Binding SelectedFolderItem.DestinationFolder}" />

then it works although this is not desired (it just loops the correct number of times but only for the 1 item!).

Can some one point me in the right direction?

Answer 1

You are setting a different DataContext. You don't need that, otherwise you destroy the purpose of the item template.

<StackPanel Orientation="Horizontal">
    <StackPanel>
        <TextBlock Text="{Binding SourceFolder}" />
        <TextBlock Text="{Binding DestinationFolder}" />
        <Button Content="Edit"
                Command="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type ListBox}}, Path=DataContext.EditCommand}"
                CommandParameter="{Binding}"/>
    </StackPanel>
</StackPanel>

of course if you want the buttons to work aswell, you just move the relative source you currently have to the binding of the button.