Tell me more ×
Drupal Answers is a question and answer site for Drupal developers and administrators. It's 100% free, no registration required.
up vote 1 down vote favorite

I submitted my first, (and very small patch) here, by following the instructions here.

It looks like the patch worked, but when I look at the Commits tab of my profile, I don't see any entries.

When using Git, I created a new branch for the issue, made the changes, and then checked in. Should I have switched back to the dev branch and checked in?

share|improve this question
The maintainer of the module has not committed the patch, yet. It is too early for the commit to appear in your user profile, if it is going to appear. – kiamlaluno♦ Feb 23 at 14:20

1 Answer

up vote 3 down vote accepted

Commits submitted in the issue queue are only counted when the maintainer accepts them and credits you with the patch. Otherwise, people could just spam useless patches through drupal.org to increase their commit counts.

share|improve this answer
Thank you. Did I use the correct status? patch (to be ported) ??.. And how does the maintainer know that I made the commit? I can't see a username or email in the patch file? – Kye Feb 23 at 0:34
1  
No, the status should be "needs review". "To be ported" is when a patch has been reviewed by the community and is ready to go but still has to be ported for the D6/D7/D8 version of the model. The maintainer will know you made the commit because the patch was posted by your user account. Instructions for giving credit for maintainers: drupal.org/node/52287 – Patrick Kenny Feb 23 at 0:41
1  
ALso note that unless you push it, all the changes are commited only to your local repo. – Ayesh K Feb 23 at 1:56
Ayesh - why do I need to push changes via GIT when I have uploaded the patch file? Is it one or the other? – Kye Feb 23 at 4:37

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.