up vote 0 down vote favorite

I am trying to write a universal function for several html option elements I have inside a form. The option list will differ for each element so what I want to do is display the options based on the 'id' that references them in my mysql table, this will be an array. The table has 2 columns the first 'id' which is just a number and the second 'prod_option' which is the value I would like displayed. Please can someone explain what is wrong with my code?

This is where I invoke the function inside the select element. I have no problems with the connection.

//This should select 'prod_option' for id's 1,2 & 3 for example
<td><div class="formInput"><label>Cap or Vac:</label>
<select name="pack_req" id="pack_req[]" 
value="**<?php $newProd->packRequirements(1,2,3); ?>**" /></select></div></td>


//function in class
public function packRequirements($values){
$con = $this->connection;
$itms = array($values);

$sql = $con->query("SELECT `prod_option` 
FROM `packaging_requirements` 
WHERE `id`    IN('".implode("', '", $itms)."')"); 

while($r = $sql->fetch_array(MYSQLI_ASSOC)):
echo '<option value="'$itms['prod_option']'"</option>';  
endwhile;

}
share|improve this question

5 Answers

up vote 1 down vote

You might want to put your function between the select tags like:

<select><?php $newProd->packRequirements(1,2,3); ?></select>

Instead of:

<select value="**<?php $newProd->packRequirements(1,2,3); ?>**"></select>
share|improve this answer
up vote 1 down vote

Your HTML appears to be wrong. A select goes like this:

<select name="myname">
    <option value="42">Everything</option>
</select>

But instead, your code generates

<select name="pack_req" id="pack_req[]" value="**<option value=".
share|improve this answer
Thank you for your quick reply. I have made the change you recommended to the select option. However, it still does not echo any values.I'm not sure if I should echo the $itms['prod_option']. Maybe I should echo the result but not sure how. – paynod Apr 18 '12 at 12:56
Compare what should be there vs what is there. Your <option> code is off. Likely it should be echo "<option>{$itms['prod_option']}</option>"; – pp19dd Apr 18 '12 at 13:09
up vote 0 down vote 
<td><div class="formInput"><label>Cap or Vac:</label>
<select name="pack_req" id="pack_req[]">
**<?php $newProd->packRequirements(1,2,3); ?>**</select></div></td>


//function in class
public function packRequirements($values){
$con = $this->connection;
$itms = array($values);

$sql = $con->query("SELECT `prod_option` 
FROM `packaging_requirements` 
WHERE `id`    IN('".implode("', '", $itms)."')"); 

while($r = $sql->fetch_array(MYSQLI_ASSOC)):
echo '<option value=".$itms['prod_option'].">'.$itms['prod_option'].'</option>';  
endwhile;

}
share|improve this answer
Ok, I have ammended my code to look like this: – paynod Apr 18 '12 at 13:04
Ok, I have sorted the error message. The problem I have is that it only returns the first value in the array for example if I use $newProd->packRequirements(array(1,2,3)); then it will only return prod_option with id 1. The other options are not displayed....why? aaaaagh! – paynod Apr 18 '12 at 14:04
Ok, I sorted it. Maybe this will help someone else. Here is my modified code: $items = implode(",", $itms); $sql = $con->query("SELECT prod_option FROM packaging_requirements WHERE id IN({$items})"); – paynod Apr 18 '12 at 14:23
up vote 0 down vote

you have to write like this:

<select name='selectName'><?php newProd->packRequirements(array(1,2,3)) ?></select>



public function packRequirements($itms = array()) {
   $con = $this->connection;

   $sql = $con->query("SELECT `prod_option` FROM `packaging_requirements` WHERE `id` IN('" . implode(",", $itms) . "')"); 

  while($r = $sql->fetch_array(MYSQLI_ASSOC)) {
     echo '<option value="' . $r['prod_option'] . '">' . $r['prod_option'] . '</option>';
  }
}
share|improve this answer
It now retrieves the first 'prod_option' which is VAC but also displays this error: Warning: implode() [function.implode]: Invalid arguments passed in C:\wamp\www\includes\newLineForm.class.php on line 16 Line 16 is the $sql statement – paynod Apr 18 '12 at 13:22
up vote 0 down vote

try this :

public function packRequirements($values = array())
{
   $result ='';
   $string =  implode(',', $values);

   $sql = $con->query("SELECT `prod_option` 
                      FROM `packaging_requirements` 
                      WHERE `id`    IN('".$string."')");
   while($r = $sql->fetch_array(MYSQLI_ASSOC)){
        $result .= '<option value=".$r['prod_option'].">'.$r['prod_option'].'</option>';  
   }
 return $result;

}

<select name="pack_req" id="pack_req[]">
**<?php echo $newProd->packRequirements(arra(1,2,3)); ?>**
</select>
share|improve this answer

Your Answer

 
or
required, but never shown
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.