Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I'm trying to use a PHP function to read a server directory for images. The images will then need to be passed back to JQuery using .ajax() for use in a slideshow. I'm using the PHP function hoping to simplify adding/removing images for my user. Basically, all they'd have to do is add or remove images from the directory to modify the slideshow and not edit any code.

I'm struggling to get the JQuery function to return what I'm expecting. It's been a while since I've done PHP so I may be overlooking someone. Here's my PHP code:

<?php
    $path = "./";
while (false !== ($file = readdir($handle)))
    {
        if ($file != '.' && $file != '..')
            echo "<img src=\"" . $path.$file. " alt=\"" . $file . "\>";
        {
    }
?>

Here's my readImages JQuery function:

function readImages() {
    $.ajax({
        type: "POST",
        url: "getimages.php",
        dataType: "html",
        success: function(imagepath){
            $(".slideshow").html(imagepath);
            }
    });

}

What I'm trying to do is get the PHP to return an HTML formatted tag with the file name added. The JQuery then adds the returned tag to the HTML code.

So far... all it's returning is "; { } ?>

Any ideas as to what I'm doing wrong?

share|improve this question

3 Answers

up vote 0 down vote accepted

The main issue is the borken if structure Rob Olmos pointed out. But i would also switch to directory iterator instead of readfile if youre using php5.

<?php
    $path = "./";
    $dir = new DirectoryIterator(realpath($path));
    $img = '<img src="%s" alt="%s" />';

    foreach($dir as $file){
      if(!$dir->isDot() && 0 !== strpos('.', $file->getFilename()) && !$file->isDir()){
        $filepath = $path . $file->getFilename();
        echo sprintf($img, $filepath, $filepath);
      }
    }
?>
share|improve this answer
Here's what the above code returns - "; } } ?> '; foreach($dir as $file){ if(!$dir->isDot() && 0 !== strpos('.', $file->getFilename()) && !$file->isDir()){ $filepath = $path . $file->getFilename(); echo sprintf($img, $filepath, $filepath); } } ?> Seems like something I'm doing in JQuery is writing the PHP as it's written. – miraclechalk Dec 1 '10 at 3:53
you do have php installed and running correct? And youre accessing the file via http:// not file:// correct? Also is there any code being included before this? – prodigitalson Dec 1 '10 at 5:07
You are correct. I didn't even look at the address bar. Once I viewed using localhost, it worked. Thanks for the help. – miraclechalk Dec 1 '10 at 23:23
up vote 0 down vote

Since you say it's returning this...

"; { } ?>

My first guess would be you have a syntax error somewhere in closing your PHP up. Missing quote maybe?

The rest of this looks correct.

share|improve this answer
up vote 3 down vote

Your if() structure is broken. Missing a beginning and ending curly brace.

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.