up vote 0 down vote favorite

Hi guys my if statement is not working. I want to basically do nothing is the array is empty or do something if it has values. All that happens is "no extras selected" is displayed even if i select extras 

if (empty($extras)) { 
    $message .="<br /> No extras selected <br />";
    } else { 
    foreach($_POST['extras'] as $extra)
    {
      $message .="<br />Extras: ".$extra."<br />";

    } 
    }
share|improve this question
yes it is an array of checkboxes – Simon Apr 28 '11 at 12:51

closed as too localized by Alexander, SztupY, Mario, tc., Tomasz Kowalczyk Mar 6 at 21:05

This question is unlikely to help any future visitors; it is only relevant to a small geographic area, a specific moment in time, or an extraordinarily narrow situation that is not generally applicable to the worldwide audience of the internet. For help making this question more broadly applicable, see the FAQ.

8 Answers

up vote 4 down vote accepted

I'm assuming this is a typo, as according to your code $extras is never set.

You should be using

if (empty($_POST['extras'])) {
share|improve this answer
up vote 1 down vote

Possibly $extras variable is empty, but you're iterating through $_POST['extras'] which is not the same.

share|improve this answer
thanks for the help mate – Simon Apr 28 '11 at 13:00
up vote 0 down vote

I haven't tested this, but you can try an if(!isset($extras[0]))

share|improve this answer
nope, still dosent work – Simon Apr 28 '11 at 12:47
up vote 0 down vote

What about

if ( empty($_POST['extras']) ) { ... }

?

Have you declared $extras variable before ?

share|improve this answer
$extras is an array of checkboxes which are stored in $_POST – Simon Apr 28 '11 at 12:48
up vote 0 down vote 
if(!empty($array)){
//do something
}else{
//donothing

}

Please try this.,....

share|improve this answer
up vote 0 down vote

You can try also with the is_array() function. Documentation here

share|improve this answer
up vote 0 down vote

If you've assigned an empty array to the $extras variable in your code (for example $extras = array(), then you're essentially checking the assignment of $extras, rather than the length of the array assigned thereto.

This should work for you:

if(count($extras) == 0) {  
    // Your code here...
}
share|improve this answer
up vote 0 down vote

I think your code should be this:

if (array_key_exists('extras', $_POST) and // check that the element exists in the $_POST array
    !empty($_POST['extras'])) { // check that it is not empty
     foreach ($_POST['extras'] as $extra) {
        $message .="<br />Extras: " . $extra . "<br />";
     }
} else {
    $message .="<br /> No extras selected <br />";
}

Currently the logic in your code is backwards.

share|improve this answer
Cheers heaps for the help – Simon Apr 28 '11 at 13:01

Not the answer you're looking for? Browse other questions tagged or ask your own question.