Hi,EveryOne! I want to develop my own MVC framework.This is a very small framework. I have tested this framework and it's working fine. I can do CRUD without any troubles. I am using Smarty to handle the view section. I still feel I can improve this framework and also I want to find out whether I'm doing something wrong here. Could you please spend a moment to check this? Please tell me how can I improve this mini framework. Are there any errors or wrong implementations? Anything violates OOP structure? Any comments will be highly appreciated.
index.php this is the 1st file to run. It just do all the includes and initiate the bootstrap class.
<?php
session_start();
/*For debugging*/
error_reporting(E_ALL);
require_once('libs/core/Bootstrap.php');
require_once('libs/core/Model.php');
require_once('libs/core/View.php');
require_once('libs/core/Controller.php');
require_once('libs/core/Database.php');
require_once('libs/smarty/Smarty.class.php');
require_once('application/config/config.php');
/* Initiate Bootstrap */
**$bootstrap = new Bootstrap();**
?>
Bootstrap.php explode the url('/') and get the controller name and the method name. Load the controller. Load the method. Pass the parameters(callControllerMethod()). Currently I can pass up to 3 paraments. If the controller/method is invalid index controller will run.
<?php
class Bootstrap {
private $url = array();
private $controller = null;
private $controllerPath = 'application/controllers/'; // Always include trailing slash
private $defaultFile = 'index.php';
function __construct() {
$this->url = $this->getUrl();
if (empty($this->url[0])) {
$this->loadDefaultController();
return false;
}
$this->loadExistingController();
$this->callControllerMethod();
}
private function getUrl() {
$url = isset($_GET['url']) ? $_GET['url'] : NULL;
$url = rtrim($url, '/');
$url = filter_var($url, FILTER_SANITIZE_URL);
$this->url = explode('/', $url);
return $this->url;
}
private function loadDefaultController() {
require_once($this->controllerPath . $this->defaultFile);
$this->controller = new Index();
$this->controller->index();
}
private function loadExistingController() {
$file = $this->controllerPath . $this->url[0] . '.php';
if (file_exists($file)) {
require_once($file);
$this->controller = new $this->url[0]();
} else {
die('404 Controller is missing!');
}
}
private function callControllerMethod() {
//Get array length
$length = count($this->url);
if($length > 1){
if (!method_exists($this->controller, $this->url[1])) {
die('404 Method is missing!');
}
}
switch ($length) {
case 5:
//Controller->Method(Param1, Param2, Param3)
$this->controller->{$this->url[1]}($this->url[2], $this->url[3], $this->url[4]);
break;
case 4:
//Controller->Method(Param1, Param2)
$this->controller->{$this->url[1]}($this->url[2], $this->url[3]);
break;
case 3:
//Controller->Method(Param1)
$this->controller->{$this->url[1]}($this->url[2]);
break;
case 2:
//Controller->Method()
$this->controller->{$this->url[1]}();
break;
default:
$this->controller->index();
break;
}
}
}
?>
Base View.php Initiate Smarty, Set the Smart dir paths. Set values to the template. Load the content inside the base template. In the default_theme.tpl i'm calling {include file=$content} to lad the custom content.
<?php
class View {
protected $data;
protected $smarty;
function __construct() {
$this->data = array();
//View
$this->smarty = new Smarty();
$this->smarty->setTemplateDir('application/views/templates/');
$this->smarty->setCompileDir('application/views/templates_c/');
$this->smarty->setConfigDir('application/views/configs/');
$this->smarty->setCacheDir('application/views/cache/');
//$this->smarty->debugging = true;
}
public function set($key, $val) {
$this->smarty->assign($key, $val);
}
public function render($view) {
$this->smarty->assign('content', $view.'.tpl');
$this->smarty->display('base/default_theme.tpl');
}
}
?>
Base Controller.php
class Controller {
protected $view;
protected $model;
function __construct() {
$this->view = new View();
$this->model= new Model();
}
}
?>
Base Model.php I have my own Database.php(PDO class). I have included the model load function here. (load) So from the controller I can do $this->helpModel = $this->model->load('help_model');
protected $db;
function __construct() {
$this->db = new Database(DB_TYPE, DB_HOST, DB_NAME, DB_USER, DB_PASS);
}
function load($name) {
$path = 'application/models/'. $name .'.php';
if (file_exists($path)) {
require_once($path);
return new $name();
} else {
die('Error: Model is not existing.');
}
}
}
?>
This is one of my sample controllers
<?php
class help extends Controller{
private $helpModel;
function __construct() {
parent::__construct();
$this->helpModel = $this->model->load('help_model');
}
function index(){
//get data
$data = $this->helpModel->selectAll();
//set data
$this->view->set('data',$data);
$this->view->render('customer/cust');
}
public function addUser(){
if($_POST){
extract($_POST);
//testing insert
$data2["name"] = 'asdasdsd';
$data2["email"] = 'asdasdsd';
$data2["pass"] = 'asdasdsd';
$data2["added"] = date("Y-m-d");
$this->helpModel->create($data2);
}
$this->index();
}
function other($val = false) {
echo "inside other function<br/>";
echo "value $val <br/>";
//$this->index();
}
function another($val1,$val2) {
echo "inside other function<br/>";
echo "value $val1 and $val2 <br/>";
//$this->index();
}
}
?>
My sample Model
<?php
class help_model extends Model {
function __construct() {
parent::__construct();
}
public function selectAll() {
$results = $this->db->selectAll("users");
return $results;
}
public function create($data) {
$values = array(
"admin_name"=>$data["name"],
"admin_email" =>$data["email"],
"admin_pass" =>$data["pass"],
"admin_added" =>$data["added"]
);
$results = $this->db->insert("admins",$values);
return $results;
}
}
?>
Sample View
<h3>Add Record</h3>
<form action="{$smarty.const.BASE}help/addUser" method="post">
<table>
<tr>
<td><label for="name">Name:</label></td>
<td><input type="text" name="name" /></td>
</tr>
<tr>
<td><label for="email">Email:</label></td>
<td> <input type="text" name="email" /></td>
</tr>
<tr>
<td colspan="2">
<input class="btn btn-success" type="submit" value="Submit" name="submit"/>
<button class="btn">Cancel</button>
</td>
</tr>
</table>
</form>
<br/>
<table class="table">
<thead>
<tr>
<th>Stauts</th>
<th>Name</th>
<th>Email</th>
<th>Token</th>
<th>Option</th>
</tr>
</thead>
<tbody>
{foreach from=$data item=foo}
<tr>
<td>{$foo['user_status']}</td>
<td>{$foo['user_name']}</td>
<td>{$foo['user_email']}</td>
<td>{$foo['user_token']|truncate:40}</td>
<td><a href="">Edit</a> /<a href="">Delete</a></td>
</tr>
{/foreach}
</tbody>
</table>
Database.php
<?php
class Database extends PDO {
public function __construct($DB_TYPE, $DB_HOST, $DB_NAME, $DB_USER, $DB_PASS) {
$options = array(
PDO::ATTR_PERSISTENT => true,
PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION
);
try {
parent::__construct($DB_TYPE.':host='.$DB_HOST.';dbname='.$DB_NAME, $DB_USER, $DB_PASS, $options);
} catch (PDOException $e) {
die($e->getMessage());
}
}
public function selectAll($table, $fetchMode = PDO::FETCH_ASSOC) {
$sql = "SELECT * FROM $table;";
$sth = $this->prepare($sql);
$sth->execute();
return $sth->fetchAll($fetchMode);
}
public function select($sql, $array = array(), $fetchMode = PDO::FETCH_ASSOC) {
$sth = $this->prepare($sql);
foreach ($array as $key => $value) {
$sth->bindValue("$key", $value);
}
$sth->execute();
return $sth->fetchAll($fetchMode);
}
public function insert($table, $data) {
ksort($data);
$fieldNames = implode('`, `', array_keys($data));
$fieldValues = ':' . implode(', :', array_keys($data));
$sth = $this->prepare("INSERT INTO $table (`$fieldNames`) VALUES ($fieldValues)");
print_r($fieldValues);
foreach($data as $key => $value) {
$sth->bindValue(":$key", $value);
}
$sth->execute();
}
public function update($table, $data, $where) {
ksort($data);
$fieldDetails = NULL;
foreach ($data as $key => $value) {
$fieldDetails .= "`$key`=:$key,";
}
$fieldDetails = rtrim($fieldDetails, ',');
$sth = $this->prepare("UPDATE $table SET $fieldDetails WHERE $where");
foreach ($data as $key => $value) {
$sth->bindValue(":$key", $value);
}
$sth->execute();
}
public function delete($table, $where, $limit = 1) {
return $this->exec("DELETE FROM $table WHERE $where LIMIT $limit");
}
}
-PS Can I just check isUserLoggedIn() in the Bootstrap.php class inside the __construct function? if loggedIn run the custom controller if not run the default controller.
