Accessing the only element of Java ResultSet

Why not just do it like

while(rs.next()) {
   result.put(....);
   return result;
}

You can also wrap it into try-catch-finally...

And also, the use of prepared statement may not be justified in this example, since you use it only once.

Here is a bit reworked version of you code. Some explanation:

• Assume _TABLE_NAME is a constant, so there is no need to build query in every method call.
• Force getting connection and close resources to avoid side effects.
• Propagate SQLException to caller (caller should decide what to do with thrown exception).

Code:

private final static String GET_DATA_BY_ID = "select * from " + _TABLE_NAME + " where id = ?";

public Map<String, String> getById(long id) throws SQLException {

    Connection conn = null;
    Map<String, String> result = new HashMap<String, String>();

    try {
        conn = getConnection();

        PreparedStatement preparedStatement = null;

        ResultSet rs = null;
        try {
            preparedStatement = conn.prepareStatement(GET_DATA_BY_ID);
            preparedStatement.setLong(1, id);
            try {
                rs = preparedStatement.executeQuery();

                if (rs.next()) {
                    ResultSetMetaData rsmd = rs.getMetaData();
                    int fieldsCount = rsmd.getColumnCount();

                    for (int i = 1; i < fieldsCount + 1; i++) {
                        String cName = rsmd.getColumnName(i);
                        result.put(cName, rs.getString(cName));
                    }
                }
            } finally {
                if (rs != null)
                    rs.close();
            }
        } finally {
            if (preparedStatement != null)
                preparedStatement.close();
        }
    } finally {
        if (conn != null)
            conn.close();
    }
    return result;
}

You don't need check if (rs != null) and if (preparedStatement != null), because prepareStatement() and executeQuery() always return non-null or fails. Just declate these objects without initialization and close them after. Same for connection probably.

Sergey's answer highlights the importance of closing the resources - if you omit that, you'll have a connection leak, which means that the database will run out of connections. In a long-running application this is a critical bug, so the ugly try-finally-approach is fully justified. (You could actually hide it by wrapping it in an utility class.)

Checking the ResultSet and PreparedStatement obtained from the JDBC implementation for null is not necessary, since if e.g. obtaining the result set by rs = preparedStatement.executeQuery() did fail already, that means it cannot be closed anyway.

However, I would not throw the raw SQLException to the client, but wrap them in an application specific exception. This allows you to treat different error conditions differently, and decouples your calling code from the SQL layer, which is useful should you want to switch to another persistence mechanism later. (Also, it is very simple.)

private final static String GET_DATA_BY_ID = 
        "select * from " + _TABLE_NAME + " where id = ?";

public Map<String, String> getById(long id) throws YourSpecificPersistenceException {

    final Map<String, String> result;
    try {
        Connection conn = getConnection();
        try {

            PreparedStatement preparedStatement = 
                    conn.prepareStatement(GET_DATA_BY_ID);

            try {
                preparedStatement.setLong(1, id);
                ResultSet rs = preparedStatement.executeQuery();

                try {
                    if (rs.next()) {
                        ResultSetMetaData rsmd = rs.getMetaData();
                        int fieldsCount = rsmd.getColumnCount();
                        result = new HashMap<String, String>(fieldsCount);

                        for (int i = 1; i < fieldsCount + 1; i++) {
                            String cName = rsmd.getColumnName(i);
                            result.put(cName, rs.getString(cName));
                        }
                    } else {
                        result = Collections.emptyMap();
                    }
                } finally {
                    rs.close();
                }
            } finally {
                preparedStatement.close();
            }
        } finally {
            conn.close();
        }
    } catch (SQLException e) {
        throw new YourSpecificPersistenceException("Unable to execute statement: '"
                + GET_DATA_BY_ID + "' with parameter [" + id + "]", e);
    }
    return result;
}