PHP Error in MySQL Syntax

Question

Here's the function I created:

function get_phurl_option($option) {
$db_result  =   mysql_query("SELECT value FROM ".DB_PREFIX."options WHERE option = '$option'") or db_die(__FILE__, __LINE__, mysql_error());
$db_row     =   mysql_fetch_row($db_result);
return $db_row[0];
}

However, upon visiting a page that uses the function, I get the following error:

File: /usr/home/<removed>/includes/functions.php
Line: 28
Message: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'option = 'shortcode_type'' at line 1

I'm not sure why this would be, I've tried apostrophes, speech marks, and backticks, neither of which seem to work. I can't figure out the problem here, so any help would be much appreciated.

Escape your variables correctly, it will save you lots of errors and nerves. — F.P
– F.P, Commented May 29, 2012 at 9:13
What does $option look like? The query itself looks fine, assuming DB_PREFIX is set — Ahatius
– Ahatius, Commented May 29, 2012 at 9:14
Echo out the final query before executing it... That will allow you to see exactly where the problem is... — Lix
– Lix, Commented May 29, 2012 at 9:14
Please don't use mysql_* functions in new code. They were removed from PHP 7.0.0 in 2015. Instead, use prepared statements via PDO or MySQLi. See Why shouldn't I use mysql_* functions in PHP? for more information. — tereško
– tereško, Commented May 29, 2012 at 9:16

Mark Baker · Accepted Answer · 2012-05-29 09:14:45Z

6

option is a MySQL reserved word, so you need to enclose it in backticks

$db_result  =   mysql_query("SELECT value FROM ".DB_PREFIX."options WHERE `option` = '$option'")

answered May 29, 2012 at 9:14

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Death · Accepted Answer · 2012-05-29 09:16:23Z

1

The specified error usually means that the field you're attempting to access is invalid or reserved by MySQL. Make sure you escape all variables in backticks:

SELECT `value` FROM `".DB_PREFIX."options` WHERE `option` = '$option'

answered May 29, 2012 at 9:16

Death

2,01713 silver badges14 bronze badges

Collectives™ on Stack Overflow

PHP Error in MySQL Syntax

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related