This tag is for questions about the practice of code review and code walkthroughs.
6
votes
1answer
283 views
What is a“ feature envy” code and why is it considered a code smell?
This question on SO talks about correcting what the OP thought is feature envy code. Another example where I saw this nifty phrase being quoted is in a recently given answer here in programmers.SE. ...
0
votes
3answers
293 views
Best practice to store DateTime based on TimeZone
Developing a web application which should allow User to schedule appointment based on their TimeZone. And I am storing the User scheduled datetime as server datetime into database field. While ...
-5
votes
3answers
363 views
breaking a bad habit [closed]
I have a bad habit of not properly naming my variables, I will often use just the letters ABC and add a number to the letter making it a1 or b2 this is making debuging more difficult, when i ask a ...
30
votes
5answers
909 views
Is it appropriate to have positive comments in code reviews, or is it exclusively for constructive criticism?
I have been doing a lot of code review lately, and I am unsure of the positive and negative effects and professionalism of putting positive and/or funny comments in code reviews.
We use Github as our ...
1
vote
2answers
212 views
Should the search engine return a dictionary or strongly typed objects?
I'm building a search engine using Lucene.NET / Solr.NET, and I'm wondering should search hits be returned as a dictionary or strongly typed object.
public class SearchResult
{
public string ...
4
votes
3answers
534 views
Code review if nobody in team has knowledge in some technology?
Sample situation: A team of Java developers starts an iOS project. Only one developer has Objective-C/iOS knowledge, and in the beginning he will work on this project alone.
How we can perform code ...
1
vote
4answers
307 views
Can I perform a code review although I am very inexperienced? [closed]
I have been teaching myself Python as a first language for 2 years now. So far I have done some online courses (NLP, Design of a Computer Program etc.) and solved some puzzles but never worked with ...
19
votes
9answers
1k views
What exactly makes code “clean”? [duplicate]
I am an intern at a small software company, doing typical grunt work. Many tasks that the actual developers are doing are above my head however I finally got to see some real "action" and write some ...
1
vote
1answer
195 views
Checklist for coding MVVM web application [duplicate]
We are a small team working on a web application using MVVM design pattern using technologies like .NET, Knockout and HTML. I am trying to come up with a code review checklist for this, so that my ...
1
vote
3answers
128 views
How to integrate code reviews to a team [duplicate]
I work in a team that keeps growing. However, there are no code reviews and I see this as a problem every day. There are people with really limited skills committing code to our repository that I ...
27
votes
9answers
3k views
What should I do when waiting for a review?
Before asking my question, I must explain the situation.
I'm working for a company as a junior software engineer. One of the seniors always stops me when I have finished my development and want to ...
3
votes
1answer
189 views
How can I make being code reviewed by someone who doesn't know the language easier?
I'm in a team where I am the only Java developer. The rest of the team are VERY experienced in their own programming language, but their area of expertise is not object orientated.
I found the first ...
65
votes
8answers
8k views
Refusing to review code
I am in a position where I have been asked to review some code that fixes a problem that I don't believe exists.
The fixer, who is more senior than me, insists his fix is necessary but it appears ...
6
votes
4answers
331 views
How should I implement code review in this situation?
My question is about how to put code review into practice in a workplace where nobody else has asked for it, I've never done it before, and I'm not entirely sure if it's worthwhile for this type of ...
2
votes
5answers
205 views
Who is responsible for fixing failed SQL code reviews? [closed]
As a DBA, most SQL is submitted to my team for review. We do not have a SQL developer, so the code is frequently very, very inefficient.
Our current process is:
SQL is submitted for review right ...
