current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite
1

I am trying to validate input from a user.The user puts in Y coordinate a letter between (A-J) and x coordinate a number between (1-9).I can validate the y coordinate but am having trouble validating the x coordinate. I want it so if the user puts in something other than a number between 1 and 9 it keeps asking the user for valid input.

    do {
        // inner loop checks and validates user input
        do {

            System.out.println("Enter X Co-Ord (A-J), or Q to QUIT");
            letter = input.next().toUpperCase(); // upper case this for
                                                    // comparison
            if (letter.equals("Q"))
                break; // if user enters Q then quit

            String temp = "ABCDEFGHIJ";

            while (temp.indexOf(letter) == -1) {
                validString = false;
                System.out.println("Please enter a valid input");
                letter = input.next().toUpperCase();
                col = temp.indexOf(letter);

            }

            if (temp.indexOf(letter) != -1) {
                validString = true;
                col = temp.indexOf(letter);

            }
            try {

                System.out.println("Enter Y Co-Ord (0-9)");
                row = input.nextInt();


            } catch (InputMismatchException exception) {
                validInt = false;
                System.out.println("Please enter a number between 1 -9");
            }

            catch (Exception exception) {
                exception.printStackTrace();
            }

            valuesOK = false; // only set valuesOK when the two others are
                                // true
            if (validString && validInt) {
                valuesOK = true;
            }
        } while (!valuesOK); // end inner Do loop

The output is:

Enter X Co-Ord (A-J), or Q to QUIT

d

Enter Y Co-Ord (0-9)

h

Please enter a number between 1 -9

Enter X Co-Ord (A-J), or Q to QUIT

Enter Y Co-Ord (0-9)

share|improve this question
1  
You'll want to align your text; one says 0-9, one says 1-9. –  Dave Newton Jan 18 '13 at 17:05
add comment

2 Answers 2

up vote 1 down vote

You just need to put a while loop around your nextInt() the same as you do when reading the letter:

  System.out.println("Enter Y Co-Ord (0-9)");
  row = -1
  while (row < 0) {
    try {
      row = input.nextInt();
      validInt = true;
    } catch (InputMismatchException exception) {
      System.out.println("Please enter a number between 1 -9");
      row = -1;
      validInt = false;
    }
  }
share|improve this answer
    
It seems to go into an infinite loop now... –  user1899672 Jan 18 '13 at 17:22
    
Edited. I dropped the validInt flag by mistake. –  Mike Clark Jan 18 '13 at 17:25
    
Please, use new syntax for try catch, it will look nicer. –  Alex Kreutznaer Jan 18 '13 at 17:32
    
What are you referring to by "validInt flag"? sorry, I'm new to programming. –  user1899672 Jan 18 '13 at 18:18
    
I was meaning the validInt boolean value that you had inside the catch block in your original code above. –  Mike Clark Jan 18 '13 at 18:20
show 3 more comments
up vote 0 down vote

Just want to make the validation make more sense with the requirement, since human 's eye can skip easily the line nextInt()

String value = "";
System.out.println("Enter Y Co-Ord (1-9)");

while (!(value = input.next()).matches("[1-9]+")) {
    System.out.print("Wrong input. Insert again: ");
}

System.out.println(value);

Of course, when you get the right value, then you can parse it to integer again (safely !!!)

share|improve this answer
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.