This tag is for questions about the practice of code review and code walkthroughs.
1
vote
2answers
143 views
Code Review tools - to use or not? [on hold]
On my dev team, we're doing code reviews, however not in a proper way i believe.
The issues our process suffers from:
Not enough time is allocated for proper code review.
Doing reviews is not ...
-1
votes
0answers
13 views
Adding an entire project to a Crucible review? [migrated]
When we were two years into our last project, we started using Crucible, and adding the changes was simple. Now I've started an entirely new project, and now that people are clamoring for Crucible ...
12
votes
3answers
274 views
Strategy for code review before merge to master from feature branches
Me and my team use feature branches (with git). I'm wondering which is the best strategy for code review before merge to master.
I checkout a new branch from master, lets call it fb_#1
I commit a ...
34
votes
5answers
891 views
How to code review without offending other developers [duplicate]
I work on a team that does frequent code reviews. But it seems like more of a formality than anything.
No one really points out problems in the code for fear of offending other developers. The few ...
17
votes
2answers
956 views
What is a“ feature envy” code and why is it considered a code smell?
This question on SO talks about correcting what the OP thought is feature envy code. Another example where I saw this nifty phrase being quoted is in a recently given answer here in programmers.SE. ...
0
votes
3answers
413 views
Best practice to store DateTime based on TimeZone
Developing a web application which should allow User to schedule appointment based on their TimeZone. And I am storing the User scheduled datetime as server datetime into database field. While ...
-5
votes
3answers
372 views
breaking a bad habit [closed]
I have a bad habit of not properly naming my variables, I will often use just the letters ABC and add a number to the letter making it a1 or b2 this is making debuging more difficult, when i ask a ...
30
votes
5answers
919 views
Is it appropriate to have positive comments in code reviews, or is it exclusively for constructive criticism?
I have been doing a lot of code review lately, and I am unsure of the positive and negative effects and professionalism of putting positive and/or funny comments in code reviews.
We use Github as our ...
1
vote
2answers
232 views
Should the search engine return a dictionary or strongly typed objects?
I'm building a search engine using Lucene.NET / Solr.NET, and I'm wondering should search hits be returned as a dictionary or strongly typed object.
public class SearchResult
{
public string ...
4
votes
3answers
540 views
Code review if nobody in team has knowledge in some technology?
Sample situation: A team of Java developers starts an iOS project. Only one developer has Objective-C/iOS knowledge, and in the beginning he will work on this project alone.
How we can perform code ...
1
vote
4answers
310 views
Can I perform a code review although I am very inexperienced? [closed]
I have been teaching myself Python as a first language for 2 years now. So far I have done some online courses (NLP, Design of a Computer Program etc.) and solved some puzzles but never worked with ...
19
votes
9answers
1k views
What exactly makes code “clean”? [duplicate]
I am an intern at a small software company, doing typical grunt work. Many tasks that the actual developers are doing are above my head however I finally got to see some real "action" and write some ...
1
vote
1answer
212 views
Checklist for coding MVVM web application [duplicate]
We are a small team working on a web application using MVVM design pattern using technologies like .NET, Knockout and HTML. I am trying to come up with a code review checklist for this, so that my ...
1
vote
3answers
133 views
How to integrate code reviews to a team [duplicate]
I work in a team that keeps growing. However, there are no code reviews and I see this as a problem every day. There are people with really limited skills committing code to our repository that I ...
28
votes
9answers
3k views
What should I do when waiting for a review?
Before asking my question, I must explain the situation.
I'm working for a company as a junior software engineer. One of the seniors always stops me when I have finished my development and want to ...
3
votes
1answer
194 views
How can I make being code reviewed by someone who doesn't know the language easier?
I'm in a team where I am the only Java developer. The rest of the team are VERY experienced in their own programming language, but their area of expertise is not object orientated.
I found the first ...
69
votes
8answers
8k views
How to reject a code review that you believe is unnecessary?
I am in a position where I have been asked to review some code that fixes a problem that I don't believe exists.
The fixer, who is more senior than me, insists his fix is necessary but it appears ...
6
votes
4answers
341 views
How should I implement code review in this situation?
My question is about how to put code review into practice in a workplace where nobody else has asked for it, I've never done it before, and I'm not entirely sure if it's worthwhile for this type of ...
2
votes
5answers
211 views
Who is responsible for fixing failed SQL code reviews? [closed]
As a DBA, most SQL is submitted to my team for review. We do not have a SQL developer, so the code is frequently very, very inefficient.
Our current process is:
SQL is submitted for review right ...
10
votes
3answers
527 views
What to do when your colleagues don't value code maintainability [duplicate]
I've been working in the same software development department for a few years now. In that time, the average stay of a developer has been 6-9 months. A handful have been around for over 2 years, but ...
2
votes
3answers
409 views
What feedback is or is not appropriate for a code review? [duplicate]
I am interested in hearing some guidelines as to what feedback is or is not appropriate for a code review. My team has a very unstructured review process and I am trying to suggest some ways to ...
2
votes
0answers
76 views
How to associate a new/modified changeset with an existing review in VisualStudio 2012
I'm trying out the new Code Review tool in Visual Studio 2012. Which seems okay for the most part, but I've hit a wall in regards to when changes are required.
How should this be handled in a code ...
0
votes
4answers
188 views
How to count condition coverage
I am wondering, What would be the correct condition coverage test cases for the following condition:
if(A && E && (B || C || D))
Considering short circuiting, what cases would I ...
4
votes
2answers
609 views
code review with git-flow and github
With regular git and github I can do a code review by simply creating a pull request of the feature branch I'm working on to the master branch. How would I do code reviews with git-flow? With workflow ...
39
votes
11answers
3k views
Should Junior Programmers be involved as code reviewers in the projects of Senior Programmers?
One of my team members, a junior programmer, has impressive programming skills for his level of experience.
And during code reviews, I believe in emphasizing learning, not pointing out mistakes.
...
-1
votes
3answers
176 views
Programming task to test for focus on maintainability [closed]
I am looking for a programming task, which shows whether the coder has maintainability in mind while programming. I imagine giving a task to fix a bug in a method. It should be clear to the programmer ...
5
votes
1answer
316 views
What would Business Intelligence (BI) developers look for in code reviews?
Let me preface this with saying I am not a Business Intelligence (BI) developer. I'm a .NET developer, and I have only a vague notion of what BI is, and encompasses.
I've been an evangelist for a ...
6
votes
4answers
349 views
How do you deal with discovering bad and false code in your team? [duplicate]
Every year in january we process a big task with our system. While the performance during the task was above average the maintaince follow up is currently having a lot of trouble with jobs running too ...
62
votes
19answers
11k views
How important is it to reduce the number of lines in code?
I am a Software developer who works on J2SE (core java).
Often during our code reviews we are asked to reduce the number of lines in our code.
It's not about removing redundant code, it's about ...
6
votes
3answers
190 views
Branches/decision count in an example
Having read SO, just found this question:
if (x > y)
print (x)
else if (x < y)
print (y)
else
print (x,y)
How many branches and decisions are there? It mentiones there should ...
