PHP mySQL query remove double array

Question

In the example below I am taking an array of the ID's only to turn it into a while and then back into an array only to explode it on the comma on the page. Surely there must be an easier way of doing this.

I am after an array of the $row['ID']s

function get_other_elector_phone($telephone,$current,$criteria){
    $the_others = mysql_query("SELECT * FROM electors WHERE telephone = '$telephone' $criteria"); $results = '';
    while($row = mysql_fetch_array($the_others))  { 
    $results .= $row['ID'].','; } return $results;
}


$others = get_other_elector_phone(g('electors',$elector,'telephone'),$elector,$criteria); 
                    if($others){ $others = explode(',',$others);

Just... build and return an array instead of a string?

DaveRandom
– DaveRandom

2012-06-25 10:36:44 +00:00
Commented Jun 25, 2012 at 10:36 — DaveRandom
– DaveRandom, Commented Jun 25, 2012 at 10:36

Jesse Rusak · Accepted Answer · 2012-06-25 12:15:33Z

0

just as @daverandom said, just rebuild an array, this is the syntax :

function get_other_elector_phone($telephone,$current,$criteria){
  $the_others=mysql_query("SELECT * FROM electors WHERE telephone = '$telephone' $criteria"); 
  $results = array();
  $i=0;
  while($row = mysql_fetch_array($the_others))  { 
    $results [$i]= $row['ID'];
    $i++; 
  } 
  //results returned outside loop
  return $results;
}

$others = get_other_elector_phone(g('electors',$elector,'telephone'),$elector,$criteria);

The $others will return an array.

edited Jun 25, 2012 at 12:15

Jesse Rusak

57.3k12 gold badges103 silver badges102 bronze badges

answered Jun 25, 2012 at 10:51

mo3lyana

562 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Walrus Over a year ago

That is only returning the first result nor all of them as mine did

Joe Bowman Over a year ago

In this example, return $results needs to be outside of the while loop. You can also dispense with $i; assigning $results[] = $row['ID'] will do the same.

mo3lyana Over a year ago

thank @joe bowman, I mean like that, I just placed the wrong place

Joe Bowman · Accepted Answer · 2012-06-25 10:41:23Z

-1

instead of

function get_other_elector_phone($telephone,$current,$criteria){
  $the_others = mysql_query("SELECT * FROM electors WHERE telephone = '$telephone' $criteria"); $results = '';
  while($row = mysql_fetch_array($the_others))  { 
    $results .= $row['ID'].','; } return $results;
  }
}

just return the result of mysql_fetch_array()

function get_other_elector_phone($telephone,$current,$criteria){
  $the_others = mysql_query("SELECT * FROM electors WHERE telephone = '$telephone' $criteria"); $results = '';
  return mysql_fetch_array($the_others);
}

then there is no need to explode the output of the function.

answered Jun 25, 2012 at 10:41

Joe Bowman

5042 silver badges8 bronze badges

2 Comments

Walrus Over a year ago

Something's wrong as its getting results for a lot more than just the ID column

Joe Bowman Over a year ago

use SELECT ID ... rather than SELECT * ... if you just want the ID column.

Collectives™ on Stack Overflow

PHP mySQL query remove double array

2 Answers 2

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related