current community

your communities

more stack exchange communities

Stack Exchange
tour help
stack overflow careers
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 0 down vote favorite

I've got a string with many lines and in each line contains a number of elements. I'm only after a third element of each line. Is there anything from with this chunk of code?

String[] separate = getArray().split("\n");
for (int i = 0; i < separate.length; i++)
{
    String[] inner = separate[i].split("/");
    for (int y = 0; y < inner.length; y++)
    {
        _listArray.add(String.valueOf(inner[2]));                   
    }
}

it's not doing what it's supposed to, or maybe I'm just too tired.

share|improve this question
6  
You have to describe the problem better than "it's not doing what it's supposed to". How is it not working? –  Jim Garrison Apr 16 '13 at 18:38
    
Are you sure that getArray() returns the original string in the correct format with all the lines separated by \n ? –  maythesource.com Apr 16 '13 at 18:41
1  
Why are you calling String.valueOf( )? inner[2] is already a String –  Mel Nicholson Apr 16 '13 at 18:41

2 Answers 2

up vote 3 down vote accepted

The inner loop is not needed.

String[] lines = getArray().split("\n");
for (String line : lines) {
  String[] tokens = line.split("/");
  _listArray.add(tokens[2]);
}

You may want a safety to make sure that tokens.length >= 2

share|improve this answer
up vote 2 down vote

Isn't it suppose to be:

String[] separate = getArray().split("\n");
for (int i = 0; i < separate.length; i++)
{
String[] inner = separate[i].split("/");
if(inner.length<3)
     throw new RuntimeException("Wrong data");//or ignore line as desire
else _listArray.add(String.valueOf(inner[2]));                   
}
share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.