Tell me more ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite
1

3 hours ago, I asked a question in SO , about delete a part o an object that i liked this question to it.

delete a part of object in javascript

but now an other problem occurred when i delete from that array. I use that object to populate a FlexiGrid. but when i delete an item from that object by following code, instead of delete that item , it sets to undefined :( and flexigrid did not accept it for input data.

for (var i = 0; i < Roomdata.length; i++) {

    if(Roomdata[i].id = X) {

        delete Roomdata[i];
        break;

    }
}

for example , imaging i have 3 items in Roomdata like this : 

{item1, item2, item3}

when call this code to delete item2 , Roomdata object is look like this : 

{item1, undefined, item3}

and this is bad format to be acceptable by flexigrid as input data

It there any solution ?

thanks every body and sorry about my bad syntax(I am new in English)

regard , Foroughi

share|improve this question
possible duplicate of JavaScript Array Delete Elements -- please use the search before you ask a question. – Felix Kling Feb 20 '12 at 14:05
The accepted answer to your previous question already suggest to use splice. Why do you ask this question again? – Felix Kling Feb 20 '12 at 14:07
Sorry @Felix , but I think because I asked a question about this issue already , I asked this question to help readers to read more understandable question ,anyway sorry about that – Ali Foroughi Feb 20 '12 at 14:08
@FelixKling , because i use that reply , but it not work , but i use his idea to solve my problem, so i accepted it not because his answer is correct , because his answer give me an idea – Ali Foroughi Feb 20 '12 at 14:10
@Rob: The duplicate answer shows how to delete an element form an array which was the question. I don't think we have to spoon feed every solution in detail. See also my comment to your answer. – Felix Kling Feb 20 '12 at 14:33

3 Answers

up vote 23 down vote accepted

Walk through the array in reverse order, and use .splice to remove the element.
You have to walk in the reverse order, because otherwise you end up skipping elements See below.

for (var i = Roomdata.length-1; i >= 0; i--) {
    if (Roomdata[i].id == X) {
        Roomdata.splice(i, 1);
        break;
    }
}

What happens if you don't walk in the reverse order:

// This happens in a for(;;) loop:
// Variable init:
var array = [1, 2, 3];
var i = 0;

array.splice(i, 1); // array = [2, 3]   array.length = 2
// i < 2, so continue
i++;  // i = 1    

array.splice(i, 1); // i=1, so removes item at place 1: array = [2]
// i < 1 is false, so stop.

// array = [2]. You have skipped one element.
share|improve this answer
thank you for complete reply and its comments, anyway you help me and you are great,thanks again – Ali Foroughi Feb 20 '12 at 14:31
1  
You don't have to traverse the element in reverse order as you are terminating the loop after you call splice anyway. If you want to remove multiple elements from an array, then yes, but in this case it is not needed. – Felix Kling Feb 20 '12 at 14:33
@FelixKling You're right. However, since the accepted answer at the other question didn't work, I assume that break; have to be removed. – Rob W Feb 20 '12 at 14:37
@RobW , yes , it is because I want to remove just one item and the breke the loop, i can traverse it normaly :) – Ali Foroughi Feb 20 '12 at 14:53
2  
Should that be if (Roomdata[i].id === X) { instead (equality vs. assignment)? – Eric Smith Apr 7 '12 at 23:54
show 1 more comment
up vote 3 down vote

What you have is an Array. You should use the splice() method to remove an element from an array, not by deleteing the element.

for (var i = 0; i < Roomdata.length; i++) {

    if(Roomdata[i].id = X) {

        Roomdata.splice(i, 1);
        break;

    }
}
share|improve this answer
2  
The second argument specifies how many items have to be removed. .splice(i,0) doesn't remove anything. Even if you replace it with .splice(i,1), you're skipping elements by not accounting for the changed index. – Rob W Feb 20 '12 at 14:11
@RobW: Whoops. And as for skipping elements, he's breaking on removal anyway, so nothings going to get skipped. – Matt Feb 20 '12 at 14:41
up vote 1 down vote

Using splice in spite of delete. 

 Roomdata.splice(i, 0);

splice attribute removes blank string elements, undefined references, NULLs and FALSEs.

it will solve your problem

share|improve this answer

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.