Explore our sites

Stack Exchange
tour help
Take the tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote 3 down vote favorite 
#include "stdafx.h"
#include <iostream>

using namespace std;

int main ()
{
    for (int i = 0; i <= 3; i++) //give the user 4 guesses at the word.
    {   
        std::string guess; 
        cout <<"Guess the word" <<endl;
        cin >>guess;

        if (guess == "Dog")
        {
            cout <<"You guessed correctly. " <<endl;
            break;
        }
        else
        {
            cout <<"You guessed incorrectly. " <<endl;
        }
    }
    char f;
    cin >>f;
    return 0;
}
share|improve this question
add comment

3 Answers

up vote 4 down vote

#include "stdafx.h" is superfluous.

The standard idiom in C++ for doing something 4 times is:

for (int i = 0; i < 4; i++) {
    ...
}

Don't deviate from that pattern unless there is a good reason.

Requiring an extra character input to exit the program is a weird user experience, especially since there is no prompt. I would just get rid of char f; cin >> f;.

share|improve this answer
 
With such a "pause" in place, it's fair to assume the OP is using an IDE (probably with no built-in pause). It is also much better than system("PAUSE"). –  Jamal♦ yesterday
 
@Jamal That makes sense. (I usually don't use an IDE.) In that case, a comment would be useful: // Pause so that output can be examined when running in an IDE –  200_success yesterday
 
Fair enough. You may add that to your answer, especially for others not too familiar with such IDEs. –  Jamal♦ yesterday
add comment
up vote 4 down vote

  • Try not to use using namespace std.

  • Be sure to include <string> since you're using std::string.

  • Prefer std::getline() over operator>> for all user input (may also help with clarity):

    std::getline(std::cin, guess);

  • Does the guess have to exactly match the given word, including cases (uppercase/lowercase)? If not, then you can do something like this with std::transform():

    // get the input

// transform the guess string to all lowercase
std::transform(guess.begin(), guess.end(), guess.begin(), ::tolower);

if (guess == "dog")
{
    // ...
}

  • The "pause" at the end is okay, but here's another one:

    std::cin.ignore();
std::cin.get();

    This one doesn't involve an extra variable, although it doesn't really matter. The program still "waits" for user input before exiting.

share|improve this answer
add comment
up vote 0 down vote

Looks good to me. Don't know what the last cin >> f is for but the function runs well. Just a tip, you don't need to include the std:: scope in front of string guess, as you've already declared that you're using namespace std.

share|improve this answer
2  
Note he should not be using using namespace std; so prefer to add std:: to all the places it has been left off. The cin >> f forces the application to pause until the user hits return. If running in a hosted environment this prevents the window from closing too quickly to see the answer. –  Loki Astari yesterday
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.