current community

more stack exchange communities

Stack Exchange
tour help
Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote 1 down vote favorite

I have an open source project on GitHub. It is an ASP.NET MVC 4 application using Entity Framework and a handful of other utilities. I decided to create this project after spending about a year building a large application. I wanted it to capture the architecture I settled on and some of the cool helper classes.

I want to suggest using this open source project as a starting point for other projects that my company uses. Of course, I want some feedback to make sure I'm not giving bad advice.

This project doubles as a repository for some of the utilities I wrote. These include new ActionFilterAttributes, ActionResults and a whole lot more.

I would like someone with a lot of experience with ASP.NET MVC to take a look and see what I am missing. What problems do you see with my architecture? What are some useful helper classes that would be good to include in this repository? Are there any third-party tools for automating some of this code? Are there any view-related techniques that would simplify my UI?

share|improve this question
 
Hi Travis. I'm not sure if this is the site that could help you with this. Area there any particular classes you want reviewed? –  dreza Mar 29 '13 at 18:57
 
@dreza I was worried that might be an issue. It's such a large project - it is hard to pin point where it could stand improvement. I was hoping people with some time might look through it. –  Travis Parks Mar 29 '13 at 19:07
 
I had a brief look. Seems like something worth reading just probably not on this site? Perhaps programmers? I'm not sure really. On a side note, I didn't see any reference to any unit test functionality. Was that something you might consider? –  dreza Mar 29 '13 at 19:20
 
@dreza I think writing some unit tests would be useful. Obviously the application was designed with testing in mind. I get a lot of questions like "how do I test a controller?" It would be a good opportunity to learn how to write testable JavaScript as well. –  Travis Parks Mar 29 '13 at 19:37
 
My personal take on it is if you are going for a skinny controller (as you mention in the project doc) then controllers don't need testing. There's test frameworks for Javascript as well apparently although I haven't used those. –  dreza Mar 29 '13 at 20:38
show 2 more comments

closed as off-topic by Jamal♦ Dec 16 '13 at 2:09

This question appears to be off-topic. The users who voted to close gave this specific reason:

  • "Questions must include the code you want reviewed. Code must not appear only in a link to an external source. Doing so makes us dependent on a third-party site and makes it harder to review your code. If your code is very large, please select only the portions in which you are especially interested for a review. You are welcome to keep the link to the rest of your code." – Jamal
If this question can be reworded to fit the rules in the help center, please edit the question.