current community

your communities

more stack exchange communities

Stack Exchange
tour help
careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

I'm having a problem while adding records in SQLite.

This is the Error:

09-18 17:47:47.586: E/AndroidRuntime(1039):
   java.lang.RuntimeException: Unable to start activity ComponentInfo{com.capstone.pinoygoodies/com.capstone.pinoygoodies.GroceryView}:
   android.database.sqlite.SQLiteException: near " ":
   syntax error:
   CREATE TABLE tblItem 
                 (_id INTEGER PRIMARY KEY AUTOINCREMENT,
                  grocery_item TEXT NOT NULL,
                  grocery_qty TEXT NOT NULL

My CREATE TABLE

db.execSQL("CREATE TABLE " + DATABASE_TABLE + "(" +
KEY_ITEMID + " INTEGER PRIMARY KEY AUTOINCREMENT, " +
KEY_ITEM + " TEXT NOT NULL, " + 
KEY_QTY + " TEXT NOT NULL ");

Whenever I hit the add button, this error is being triggered.

share|improve this question
1  
Could post the code where you are creating the table? –  Lazy Ninja Sep 19 '12 at 4:45
 
add some more code –  Android Developer Sep 19 '12 at 4:46
 
Post create table code. –  Prince Sep 19 '12 at 4:51
 
i updated my code. thanks –  mharbydoll Sep 19 '12 at 5:00
 
you are missing the ) at the end. You need to include it too –  G_S Sep 19 '12 at 5:12
add comment

5 Answers

up vote 6 down vote accepted 
db.execSQL("
    CREATE TABLE " + DATABASE_TABLE + "(" +
    KEY_ITEMID + " INTEGER PRIMARY KEY AUTOINCREMENT, " +
    KEY_ITEM + " TEXT NOT NULL, " + 
    KEY_QTY + " TEXT NOT NULL );"
);

There are easy to mix up. You just need the close parenthesis.

Suggestion:

String createStatement = 
    String.format("CREATE TABLE %s ( %s INTEGER PRIMARY KEY
                   AUTOINCREMENT, %s TEXT NOT NULL, 
                   %s TEXT NOT NULL);",
                        DATABASE_TABLE,
                        KEY_ITEMID,
                        KEY_ITEM,
                        KEY_QTY);

If you construct your table like this, I personally think it makes the statement much easier to read for things like SQL Syntax and then you can bind the data later.

share|improve this answer
add comment
up vote 2 down vote

Append ")" at the end of Create Table Query.

share|improve this answer
add comment
up vote 1 down vote

error is throw by create table, not get data.

check your create table sql statement

share|improve this answer
 
Do you mind checking out my create table? :) –  mharbydoll Sep 19 '12 at 5:06
 
yes, check it... –  Mike Wei Sep 19 '12 at 5:07
add comment
up vote 0 down vote

You are missing the right parenthesis of the Create Table Syntax, correct it as follows, 

CREATE TABLE tblItem 
                 (_id INTEGER PRIMARY KEY AUTOINCREMENT,
                  grocery_item TEXT NOT NULL,
                  grocery_qty TEXT NOT NULL );
share|improve this answer
add comment
up vote 0 down vote 
db.execSQL("CREATE TABLE " + DATABASE_TABLE + "(" +
KEY_ITEMID + " INTEGER PRIMARY KEY AUTOINCREMENT, " +
KEY_ITEM + " TEXT NOT NULL, " + 
KEY_QTY + " TEXT NOT NULL )");

You need to add ")" at last in your create table.

Insert Query

    String qty = "QTY";
    String item = "ITEM";
    String sql = "INSERT or replace INTO "+ DATABASE_TABLE +" (qty, item) VALUES('"+ qty +"','"+ item + "')";
    db.execSQL(sql);
share|improve this answer
 
This works fine with me but I'm having new problem now. android.database.sqlite.SQLiteException: table tblItem has no column named qty: , while compiling: INSERT INTO tblItem(qty, item) VALUES(?, ?); I have declared the column for qty. –  mharbydoll Sep 19 '12 at 5:23
 
I update my answer for insert query.. –  V.J. Sep 19 '12 at 5:36
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.