Refactoring is a disciplined technique for restructuring an existing body of code, altering its internal structure without changing its external behavior.
1
vote
3answers
73 views
Refactoring - Utility classes behavior under a common interface
I was suggested to put my question here, so I'm doing so ;)
I need a common interface which represents some specific behavior:
public interface Contract(){
public void methodA();
public void ...
2
votes
1answer
66 views
Can removing unnecessary file from a repo be considered part of refactoring?
We're using Git as our DVCS and we're about to start to do a clean up (never done before in this team) of files that are not necessary (not part of the sources) from our products.
This is done in two ...
4
votes
5answers
427 views
Martin Fowler's Refactoring book: switch statement is using other object's data, why is that bad ? A deeper explanation is sought for.
In the code sample below the Rental object is using Movie's fields to do a switch statement. Martin says : this is a bad idea but he does not give any deeper explanation as to why ?
Of course, you ...
1
vote
3answers
112 views
Is it good to create static method at Visual Studio refactoring?
There are various refactoring options in Visual Studio to use at the time of coding. When we extract and create a new method. Then Visual Studio decide whether the new method will be static or ...
0
votes
0answers
105 views
Should I start refactor this messy project even if I know I won't have the time to completely refactor everything? [duplicate]
I have this older project (1st release 2005-ish) I've inherited that a customer asks me to fix or add something to now and then. It's a bit of a mess architecture-wise. Basically it's an ASP.NET ...
0
votes
1answer
103 views
Separating UI from logic in JavaScript modules
I'm refactoring some custom JavaScript modules written to support our mapping functionality. I'm looking to make them much more unit-testable and be able to plug pieces in and out more easily.
My ...
1
vote
3answers
81 views
How maintainable are automated refactorings? [on hold]
Resharper offered to turn my loop:
foreach (JObject obj in arr)
{
var id = (string)obj["Id"];
var accountId = (double)obj["AccountId"];
var departmentName = (string)obj["DeptName"];
...
-1
votes
0answers
28 views
JQuery: How to refactor JQuery interaction with interface?
The question is very simple but also a bit theoretical.
Let's imagine you have a long JQuery script which modifies and animate the graphics of the web site. It's objective is to handle the UI. The ...
2
votes
2answers
136 views
Replacing static classes with global state to a series of POJOs, beginning to feel like an anti-pattern
I'm trying to refactor some code, and one of the major changes is to remove the (ab)use of static classes to give global state.
I've tried to split up some of the 'global state' functionality with ...
2
votes
3answers
141 views
Should I refactor a F class from code climate? [closed]
According to code climate (static quality analysis), a class is F, aka the worst mark you could be granted.
I did submit a pull request to rearrange it here
Which has been refused because the new ...
-1
votes
1answer
88 views
What is meant by a step-by-step refactoring plan describing implementation of design [closed]
What is meant by a step-by-step refactoring plan describing how to
implement a certain design?
As little as I know about refactoring it regards improving a (UML) design model and has nothing to ...
1
vote
2answers
147 views
APIs, Versioning and Models
I have my (JSON) API structured like this (which I'm pretty happy with):
API Project
/_V1
/Controllers
V1EntityController.cs // Applies to version 1 only
/_V2
/Controllers ...
0
votes
1answer
74 views
Should a structure be refactored into smaller structures?
In one of the projects (in C), I have the code that looks like this (the names are obfuscated specially for question to not give out details of the probject):
typedef struct Module_s {
/* These ...
2
votes
2answers
162 views
How to refactor out static members of basic classes
Currently I am working on C++ project, which can be classified as "legacy" project. A lot of poor written code was committed because of lack of experience and under the pressure of deadlines. When I ...
0
votes
4answers
223 views
Usage of magic strings/numbers [closed]
This is somewhat controversial topic, and I guess there is as many opinions as there are programmers. But for the sake of it, I want to know what are the common practices in business (or in your work ...
8
votes
10answers
2k views
How to do a clean refactoring of an If Else Code without leaving any free blocks? [duplicate]
if(condition1)
{
Statement1A;
Statement1B;
}
else if(condition2)
{
Statement2;
}
else if(condition3)
{
Statement3;
}
else
{
Statement1A;
Statement1B;
}
return;
I would like to ...
42
votes
5answers
777 views
How far should we rename code and data when end users nomenclatures change?
A long time ago we added a feature where our users could "Accept" an image after it was added to a workflow queue. Turns out, we used the wrong term, and users actually "Approve" the image.
Changing ...
2
votes
4answers
155 views
Considerations before rewriting a software component from scratch? [duplicate]
A piece of software is a patchwork of old and undocumented efforts. There are no comments, no documentation, and the code is hairy -- it involves Unix shell scripts that check for dummy files and then ...
1
vote
0answers
216 views
Thoughts on refactoring a generic DAO
I have designed a generic DAO in Java and am having confusion about whether to refactor it to different design or not.
PS Don't say to use already existing 3rd person framework. I know there are some ...
3
votes
3answers
310 views
Is it Typical for Large Software Companies to Not Document or Refactor Code? [closed]
I have begun working at a large software company and was assigned to a project that is over a million and a half lines of code. It's part of a program suite that is sold to clients (not an in-house ...
1
vote
1answer
39 views
Refactoring from Python to Ruby with a BSD v3 license?
There is a project that is written in python which works great and is under the BSDv3 license. I wanted to use it as a base template for a ruby project instead of starting from scratch. I'd be ...
11
votes
7answers
1k views
Avoid too complex method - Cyclomatic Complexity
Not sure how to go about this method to reduce Cyclomatic Complexity. Sonar reports 13 whereas 10 is expected. I am sure nothing harm in leaving this method as it is, however, just challenging me how ...
11
votes
5answers
453 views
Code repetition vs multi responsible method
I try to follow the Single Responsibility Principle (SRP) and also to omit Code Repetitions. However there are often places where there are code repetitions that are nothing more than code blocks of ...
0
votes
1answer
78 views
Get entities ids from two similar collections using one method
I've got two lists:
List<Integer, ZooEntity> zoos;
List<Integer, List<ZooEntity>> groupOfZoos;
These operations will return collections of values:
Collection<ZooEntity> cz ...
9
votes
2answers
310 views
Is spreading code with refactoring comments a good idea?
I am working on a "spaghetti-code" project, and while I am fixing bugs and implementing new features, I also do some refactoring in order to make the code unit-testable.
The code is often so tightly ...
0
votes
1answer
98 views
Refactoring this code that produces a reverse-lookup hash from another hash
This code is based on the idea of a Form Object
http://blog.codeclimate.com/blog/2012/10/17/7-ways-to-decompose-fat-activerecord-models/
(see #3 if unfamiliar with the concept).
My actual code in ...
2
votes
2answers
246 views
Why delete method/field/function refactoring doesn't exist in Eclipse?
An operation in an interface is obsolete so I decided to delete it.
It seems that there is no automatic support for such a "refactoring" in Eclipse.
For me is a refactoring operation since the ...
0
votes
1answer
99 views
unit level testing, agile, and refactoring [duplicate]
I'm working on a very agile development system, a small number of people with my doing the vast majority of progaming myself.
I've gotten to the testing phase and find myself writing mostly ...
1
vote
1answer
91 views
Proper library for enums
I'm trying to refactor some code such that the display is separate from the implementation, and I'm not sure where to put the existing enums.
My project is currently structured as follows:
...
7
votes
3answers
301 views
How to refactor when all your development is on branches?
At my company, all of our development (bug fixes and new features) is done on separate branches. When it's complete, we send it off to QA who tests it on that branch, and when they give us the green ...
9
votes
5answers
1k views
How to refactor an OO program into a functional one?
I'm having difficulty finding resources on how to write programs in a functional style. The most advanced topic I could find discussed online was using structural typing to cut down on class ...
2
votes
2answers
187 views
Refactoring two classes from third-party library that could have extended a base class
I have two Classes, with very similar behaviors, both from a third party library.
Both needs to be populated with some value object and sent to specific queues in order for logging. Please note both ...
19
votes
3answers
1k views
Difficulties With TDD & Refactoring (Or - Why Is This More Painful Than It Should Be?)
I wanted to teach myself to use the TDD approach and I had a project I had been wanting to work on for a while. It wasn't a large project so I thought it would be a good candidate for TDD. However, I ...
2
votes
3answers
128 views
Should I combine similar functions even though they are slightly different?
On an application I've been working on I have a function, connecting to a virtual machine, that can be performed two ways. The user can either select a machine from a list and click the "Connect" ...
1
vote
1answer
225 views
JSP Include: one large bean or bean for each include
I want to refactor a webapp that consists of very distorted JSPs and servlets. Because we can't switch to a web framework easily we have to keep JSPs and Servlets, and now we are in doubt how to ...
3
votes
1answer
153 views
Designing and refactoring of payment logic
Im currently working on an application that helps users to coordinate dinner clubs and all related accounting. (A dinner club is where people in a group, take turns to cook for the rest and then you ...
16
votes
7answers
1k views
To rewrite or slowly refactor old C++ project [duplicate]
Our team has recently inherited a relatively large project from another company (~250k lines). It was developed using C++Builder and we intend to port the Ui side to Qt. Most of the Ui code is ...
0
votes
2answers
341 views
Refactorable God v.s. too many classe [duplicate]
So I have this problem: in order to structure my code hierarchically, for every new tiny thing, I create a separate sub-folder, file, class ... and in it one 10-line function. It is an anti-pattern.
...
1
vote
4answers
185 views
Until what point should I refactor? [duplicate]
What do you think until what point should a programmer refactor the code?
Basically having
def method
do_something
end
Pieces of code would be handy, but they increase spaghetti code until the ...
2
votes
1answer
152 views
Why does the tool offer to change the code - just because it can?
Resharper (or is it Visual Studio - it's a yellow light bulb with a tiny red filament in it) offers to "invert if" on this code:
if (tItems >= 0)
{
return tItems;
}
SetTotalItemsAndTotalAmt();
...
-1
votes
1answer
218 views
Is there a tool that visually represents all the potential paths to a particular piece of code? [closed]
As an example of what I need and why I want it, I am trying to determine how a certain value (CurTotal) is getting set (wrongly). I've come up with these notes to myself to try to understand just what ...
3
votes
4answers
558 views
Get rid of long/Complex if..else statements using Chain of Responsibility?
I've an HttpHandler, which allows users to login to a system by passing in an encrypted code.
Inside the ProcessRequest it performs quite a few steps.
Retrieve the encrypted code from request ...
4
votes
3answers
468 views
Is there a term for reusing code by retyping it?
I built a prototype ("one to throw away") a while ago, and I'm rebuilding it now as an alpha. My goodness, it's been worth it.
I reused some of the prototype code by copy-pasting then modifying it, ...
2
votes
1answer
93 views
What to name a new interface that is replacing an existing one?
We're redesigning our application's plugin interface, so we're using the Adapter pattern with our proof-of-concept design to show that the new interface will function without committing to using it in ...
9
votes
6answers
412 views
Is it better to have one method that takes a bool as a parameter or two methods with different names? [duplicate]
I'm writing a factory class for a Selenium Web Driver and I came across a choice that I couldn't figure out which is cleaner. Having two methods with the same parameter.
GetWebDriver(string browser)
...
2
votes
2answers
312 views
Refactored to a fancy global variable?
I am currently refactoring an application that i built in JavaScript.
The application uses a starting hour and a total working hour count in order to construct a timetable for daily, weekly and ...
3
votes
1answer
150 views
When to fracture a web application design into multiple products
Have you had this problem?
You are building a complex web application for a target market, and after a while you reach a point in complexity where you can't decide if you are building more than one ...
9
votes
3answers
320 views
I have to compromise: DRY, or Command-Query-Separation?
I was recently refactoring a method that was both a command and a query method.
After separating it into a one command method and one query method, I found that there are now multiple places in the ...
4
votes
2answers
157 views
How do you create documentation when there is none? [duplicate]
I have recently inherited a large, legacy system with a complex codebase that has a lack of documentation. I'm the sole internal developer embedded with the core users, taking some responsibility from ...
1
vote
1answer
247 views
Refactoring the shipping application code to use DDD factories
I was trying to find examples for using DDD factories and I came across the shipping application from Eric Evans' book.
However when I checked the BookingService the code to create a Cargo had this ...
