current community

your communities

more stack exchange communities

Stack Exchange
tour help
stack overflow careers
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote -4 down vote favorite

I am trying to Array results from a MYSQL database into a html table, however when i do this, it seems to be showing one item per row (1 column)

here is my code

<?php 

$catagory=$_GET["q"];

$con = mysql_connect("localhost","cl49-XXX","XXX");
if (!$con) 
  {
   die('Could not connect: ' . mysql_error());
   }

mysql_select_db("cl49-XXX", $con)or die( "Unable to select database");

$result=mysql_query("SELECT * FROM products WHERE catagory  = '$catagory' ")or die('You need enter a catagoryE ' );
while($row = mysql_fetch_array($result)) {
  $prodname=$row['prodname'];
  $prodID=$row['prodID'];
  echo"
  <table>
  <tr>
  <td>
  <b>$prodname </b><br>
  Product ID: $prodID<br /> 
 <img src='userpics/$prodID.jpg' height='200' width='200'></td></table> ";
}
?>

I am wanting a table with 3 columns, not 1?

share|improve this question
1  
If you create a new <table> for each record, then you're going to get a new table for each record. –  deceze Aug 2 '13 at 10:01
    
@Stephen Alright. If you create a new <table> and <td> for each record... –  deceze Aug 2 '13 at 10:13
    
It really doesn't matter if it's a new table for each record, that's not in question. "I am wanting a table with 3 columns, not 1?" -- We're talking columns not tables. If however we were talking tables, it'd be a straight forward, move the table tags outside of the loop. –  Stevovosaurus Aug 2 '13 at 10:14
    
I have managed to show all results in the table now, however the columns just go on and on, how do i limit this to 3 or 4? –  user2643837 Aug 2 '13 at 10:21

4 Answers 4

up vote 0 down vote

You need to edit code as below: 

  <table>
     <tr>
      <th>Name</th>
      <th>Id</th>
      <th>Img</th>
   </tr>
 <?php 
 while($row = mysql_fetch_array($result)) {
     $prodname=$row['prodname'];
      $prodID=$row['prodID'];
     echo"
  <tr>
      <td>$prodname </td>
      <td> $prodID</td> 
     <td><img src='userpics/$prodID.jpg' height='200' width='200'>
      </td></tr> ";
 }?>

share|improve this answer
    
is there a way to only have 3 columns? –  user2643837 Aug 2 '13 at 10:16
up vote 0 down vote

You need to create three columns in PHP echo:

<table>
<tr>
<td>
<b>$prodname</b></td>
<td>Product ID: $prodID</td> 
<td><img src='userpics/$prodID.jpg' height='200' width='200'></td>
</table>
share|improve this answer
up vote 0 down vote

You should probably create 3 columns then.

You're only creating 1 column, your code slightly cleaned up:

 <table>
   <tr>
     <td>
       <b>$prodname </b><br>Product ID: $prodID<br/><img src='userpics/$prodID.jpg' height='200' width='200'>
    </td>
   </tr>
  </table>

How about creating 3?

     <table>
      <tr>
        <td>This is a column</td>
        <td>This is a column</td> 
        <td>This is a column</td>
      </tr>
     </table>
share|improve this answer
1  
Should be a comment. –  X.L.Ant Aug 2 '13 at 10:01
3  
Most definitely not. I will not post code in a comment. –  Stevovosaurus Aug 2 '13 at 10:02
1  
Now it's ok. Previous version was not. –  X.L.Ant Aug 2 '13 at 10:02
up vote 0 down vote

Replace your while loop with this

?>
<table>
    <?php
    while($row = mysql_fetch_array($result))
    {
        $prodname = $row['prodname'];
        $prodID = $row['prodID'];
        echo "
        <tr>
            <td><b>$prodname </b></td>
            <td>Product ID: $prodID</td>
            <td><img src='userpics/$prodID.jpg' height='200' width='200'></td>
        </tr>";
    }
    ?>
<table>

Then read up on how html tables work

Update To do what you want is a very odd way to use a table, however if that's what you want, something like this should work;

?>
<table>
    <?php
    for ($i = 0; $i < mysql_num_rows($result); $i++)
    {
        $row = mysql_fetch_array($result);

        $prodname = $row['prodname'];
        $prodID = $row['prodID'];
        if ($i % 3 == 0) {
            echo "<tr>";
        }
        echo "
        <td>
            <b>$prodname </b><br />
            Product ID: $prodID<br />
            <img src='userpics/$prodID.jpg' height='200' width='200'>
        </td>";

        if (($i + 1) % 3 == 0 || ($i + 1) == mysql_num_rows($result)) {
            echo "</tr>";
        }
    }
    ?>
<table>

This should produce 3 columns per row, if you want more, change $i % 3 == 0 to $i % 4 == 0 in the two occurences

share|improve this answer
    
I have managed to show all results in the table now, however the columns just go on and on, how do i limit this to 3 or 4? –  user2643837 Aug 2 '13 at 10:20
    
The code above will show each row with 3 columns. Make sure you've copied it correctly. –  Novocaine Aug 2 '13 at 10:23
    
Sorry, in each <td> there is the prod name, prod id and image (all in the same cell) so for one product it looks like this <td> <b>$prodname </b><br /> Product ID: $prodID<br /> <img src='userpics/$prodID.jpg' height='200' width='200'></td> –  user2643837 Aug 2 '13 at 10:28
    
So you want a table that contains 3-4 columns, each to have those 3 bits of information. Then start a new row again with 3-4 columns etc...? –  Novocaine Aug 2 '13 at 10:42
    
im not sure how to do it? –  user2643837 Aug 2 '13 at 12:41

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.