Skip to main content
Tweeted twitter.com/#!/StackCodeReview/status/441841258664046593
added 116 characters in body; edited tags; edited title
Source Link
Jamal
  • 35.2k
  • 13
  • 134
  • 238

My prime Prime number generator exercise

I apologize in advance if this is the wrong venue. So I have been trying to create a class that would list prime numbers forever. I know it has already been done but I think I learned some valuable principles during my trials. This

This project helped me understand  (to a better extent) return values, arguments for methods, simple math arithmetic and what I personally enjoyed working with was the power of the forfor and ifif/elseelse statements. My code is posted below, 

I would appreciate any insight into improvements that would increase this code performance and/or any obvious flaws with my code structure.

//first the class is declared

public class startListingPrimeNumbers {

public class startListingPrimeNumbers {

    // method is created to start the prime number listing from 1 to infinity
    // and beyond
    public void startFromOneListingPrimeNumbers() {

        // Create the primary for loop using doubles so the program will
        // continue on infinitely
        for (double x = 1; x > 0.000; x = x + 1.000) {

            // The double c is for determining numbers that only have 2 factors
            // are prime
            double c = 2.000;

            // I use the primeLogger to keep track of each numbers amount of
            // factors it contains, to later compare this value to c to know if
            // it's prime or not
            double primeLogger = 0.000;

            // the multiplier is used to iterate through the for loop below
            double multiplier;

            // this is the bread and butter, I take multiplier and iterate it
            // until it is greater than x, if a remainder exists from x divided
            // by multiplier then my primeLogger adds nothing to itself
            // if there is no remainder then primeLogger adds one, meaning
            // multiplier is a factor of x.

            for (multiplier = 1.000; multiplier <= (x); multiplier = multiplier + 1.000) {
                if (x % multiplier == 0) {
                    primeLogger = primeLogger + 1.000;
                } else {
                    primeLogger = primeLogger + 0.000;
                }
            }

            // here we see if there are only 2 factors for x, and the console
            // prints the number
            if (c == primeLogger) {
                System.out.println(x + " is a prime number");
            }

            // primeLogger is set back to zero to go on to the next x value
            // based on the primary for loop description
            primeLogger = 0.000;
        }
    }
}

}

My prime number generator exercise

I apologize in advance if this is the wrong venue. So I have been trying to create a class that would list prime numbers forever. I know it has already been done but I think I learned some valuable principles during my trials. This project helped me understand(to a better extent) return values, arguments for methods, simple math arithmetic and what I personally enjoyed working with was the power of the for and if/else statements. My code is posted below, I would appreciate any insight into improvements that would increase this code performance and/or any obvious flaws with my code structure.

//first the class is declared

public class startListingPrimeNumbers {

// method is created to start the prime number listing from 1 to infinity
// and beyond
public void startFromOneListingPrimeNumbers() {

    // Create the primary for loop using doubles so the program will
    // continue on infinitely
    for (double x = 1; x > 0.000; x = x + 1.000) {

        // The double c is for determining numbers that only have 2 factors
        // are prime
        double c = 2.000;

        // I use the primeLogger to keep track of each numbers amount of
        // factors it contains, to later compare this value to c to know if
        // it's prime or not
        double primeLogger = 0.000;

        // the multiplier is used to iterate through the for loop below
        double multiplier;

        // this is the bread and butter, I take multiplier and iterate it
        // until it is greater than x, if a remainder exists from x divided
        // by multiplier then my primeLogger adds nothing to itself
        // if there is no remainder then primeLogger adds one, meaning
        // multiplier is a factor of x.

        for (multiplier = 1.000; multiplier <= (x); multiplier = multiplier + 1.000) {
            if (x % multiplier == 0) {
                primeLogger = primeLogger + 1.000;
            } else {
                primeLogger = primeLogger + 0.000;
            }
        }

        // here we see if there are only 2 factors for x, and the console
        // prints the number
        if (c == primeLogger) {
            System.out.println(x + " is a prime number");
        }

        // primeLogger is set back to zero to go on to the next x value
        // based on the primary for loop description
        primeLogger = 0.000;
    }
}

}

Prime number generator exercise

I have been trying to create a class that would list prime numbers forever. I know it has already been done but I think I learned some valuable principles during my trials.

This project helped me understand  (to a better extent) return values, arguments for methods, simple math arithmetic and what I personally enjoyed working with was the power of the for and if/else statements. 

I would appreciate any insight into improvements that would increase this code performance and/or any obvious flaws with my code structure.

//first the class is declared
public class startListingPrimeNumbers {

    // method is created to start the prime number listing from 1 to infinity
    // and beyond
    public void startFromOneListingPrimeNumbers() {

        // Create the primary for loop using doubles so the program will
        // continue on infinitely
        for (double x = 1; x > 0.000; x = x + 1.000) {

            // The double c is for determining numbers that only have 2 factors
            // are prime
            double c = 2.000;

            // I use the primeLogger to keep track of each numbers amount of
            // factors it contains, to later compare this value to c to know if
            // it's prime or not
            double primeLogger = 0.000;

            // the multiplier is used to iterate through the for loop below
            double multiplier;

            // this is the bread and butter, I take multiplier and iterate it
            // until it is greater than x, if a remainder exists from x divided
            // by multiplier then my primeLogger adds nothing to itself
            // if there is no remainder then primeLogger adds one, meaning
            // multiplier is a factor of x.

            for (multiplier = 1.000; multiplier <= (x); multiplier = multiplier + 1.000) {
                if (x % multiplier == 0) {
                    primeLogger = primeLogger + 1.000;
                } else {
                    primeLogger = primeLogger + 0.000;
                }
            }

            // here we see if there are only 2 factors for x, and the console
            // prints the number
            if (c == primeLogger) {
                System.out.println(x + " is a prime number");
            }

            // primeLogger is set back to zero to go on to the next x value
            // based on the primary for loop description
            primeLogger = 0.000;
        }
    }
}
Source Link

My prime number generator exercise

I apologize in advance if this is the wrong venue. So I have been trying to create a class that would list prime numbers forever. I know it has already been done but I think I learned some valuable principles during my trials. This project helped me understand(to a better extent) return values, arguments for methods, simple math arithmetic and what I personally enjoyed working with was the power of the for and if/else statements. My code is posted below, I would appreciate any insight into improvements that would increase this code performance and/or any obvious flaws with my code structure.

//first the class is declared

public class startListingPrimeNumbers {

// method is created to start the prime number listing from 1 to infinity
// and beyond
public void startFromOneListingPrimeNumbers() {

    // Create the primary for loop using doubles so the program will
    // continue on infinitely
    for (double x = 1; x > 0.000; x = x + 1.000) {

        // The double c is for determining numbers that only have 2 factors
        // are prime
        double c = 2.000;

        // I use the primeLogger to keep track of each numbers amount of
        // factors it contains, to later compare this value to c to know if
        // it's prime or not
        double primeLogger = 0.000;

        // the multiplier is used to iterate through the for loop below
        double multiplier;

        // this is the bread and butter, I take multiplier and iterate it
        // until it is greater than x, if a remainder exists from x divided
        // by multiplier then my primeLogger adds nothing to itself
        // if there is no remainder then primeLogger adds one, meaning
        // multiplier is a factor of x.

        for (multiplier = 1.000; multiplier <= (x); multiplier = multiplier + 1.000) {
            if (x % multiplier == 0) {
                primeLogger = primeLogger + 1.000;
            } else {
                primeLogger = primeLogger + 0.000;
            }
        }

        // here we see if there are only 2 factors for x, and the console
        // prints the number
        if (c == primeLogger) {
            System.out.println(x + " is a prime number");
        }

        // primeLogger is set back to zero to go on to the next x value
        // based on the primary for loop description
        primeLogger = 0.000;
    }
}

}