Explore our sites

Stack Exchange
tour help careers 2.0
Take the 2-minute tour ×
Stack Overflow is a question and answer site for professional and enthusiast programmers. It's 100% free, no registration required.
up vote 1 down vote favorite

im trying to replace a remove unnessary new lines with preg-replace but my regex is incorrect. Anyone any ideas whats wrong with my regex? (i have Apache/2.0.54 & PHP/5.2.9

NOW HAVE:

{
blaa {
blow;
blue};
bell;}
}ball

WOULD LIKE:

{blaa {blow;blue};bell;}}ball

These regex dont work, they remove too much or toolitle??

$buffer = preg_replace('#/\}\n|\r|\s/#s', '}', $buffer);
$buffer = preg_replace('#/\{\n|\r|\s/#s', '{', $buffer);
$buffer = preg_replace('#/\;\n|\r|\s/#s', ';', $buffer);

/g (global) gives blanc content and without the # it doestnt do anything. strange?! Anybody any clue why these dont work?

share|improve this question
1  
\s does already contain \r and \n. –  Gumbo Dec 13 '10 at 17:08
add comment

3 Answers

up vote 1 down vote accepted

If you want to remove any whitespace after {, }, and ;, do this:

preg_replace('/([{};])\s+/', '$1', $buffer)

Here / are the delimiters; ([{};]) describes one character of {, }, and ; while the match is captured; and \s+ describes any following whitespace characters (already including \r and \n).

share|improve this answer
 
Thanks Gumbo for the explanation as well!! –  Sam Dec 13 '10 at 17:45
add comment
up vote 1 down vote

This works for me:

$buffer = preg_replace('/\}\\n|\\r|\\s/', '', $buffer);
share|improve this answer
 
thanks Thariama!! –  Sam Dec 13 '10 at 17:46
 
The OP was already using single-quoted strings, so the backslashes were not the problem. (Doubling them actually had no effect; the PHP parser just removes the extras before the regex parser ever sees them.) –  Alan Moore Dec 13 '10 at 19:53
add comment
up vote 1 down vote 
$buffer = preg_replace('#([{};])(?:\n|\r|\s)#s', '$1', $buffer);
share|improve this answer
 
Thanks JoostK!! –  Sam Dec 13 '10 at 17:44
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.