current community

your communities

more stack exchange communities

Stack Exchange
tour help
Take the 2-minute tour ×
Code Review Stack Exchange is a question and answer site for peer programmer code reviews. It's 100% free, no registration required.
up vote 4 down vote favorite

Based on the true condition, I am making some operations. But I want to simplify the below HTML code in a better way.

@{
    bool savingHtml = (Request.QueryString["savehtml"] == "1");
    string activeTab = Request.QueryString["from"];
}

@if (savingHtml)
{
    if (activeTab.ToLower() == "index")
    {
        <div class="summaryTab">
    <ul class="nav nav-tabs" data-tabs="tabs">
        <li><a data-toggle="tab" href="#heat">Heat Map</a></li>
        <li class="active"><a data-toggle="tab" href="#table">Table</a></li>

    </ul>
</div>
<div class="tab-content">
    <div class="tab-pane active" id="table1">
        @Html.Partial("~/Views/Shared.MultiQuery/_resultset.cshtml", Model)
    </div>
    <div class="tab-pane" id="heat1">
    </div>

</div>
    }
    else{
        <div class="summaryTab">
    <ul class="nav nav-tabs" data-tabs="tabs">
        <li class="active"><a data-toggle="tab" href="#heat">Heat Map</a></li>
        <li><a data-toggle="tab" href="#table">Table</a></li>

    </ul>
</div>
<div class="tab-content">
    <div class="tab-pane" id="table2">        
    </div>
    <div class="tab-pane active" id="heat2">
        @Html.Partial("~/Views/Shared.MultiQuery/_resultset.cshtml", Model)
    </div>

</div>
    }
}
else
{
<div class="summaryTab">
    <ul class="nav nav-tabs" data-tabs="tabs">
        <li><a data-toggle="tab" href="#heat">Heat Map</a></li>
        <li class="active"><a data-toggle="tab" href="#table">Table</a></li>

    </ul>
</div>
<div class="tab-content">
    <div class="tab-pane active" id="table">
        @Html.Partial("~/Views/Shared.MultiQuery/_resultset.cshtml", Model)
    </div>
    <div class="tab-pane" id="heat">
    </div>

</div>
}
share|improve this question
add comment

1 Answer

up vote 2 down vote accepted

Most of your code is duplicated, what I did is extract the logic to the first code block, and left only the placeholders in the HTML.

@{
    bool savingHtml = (Request.QueryString["savehtml"] == "1");
    string activeTab = Request.QueryString["from"];
    string tabContent = Html.Partial("~/Views/Shared.MultiQuery/_resultset.cshtml", Model);
    string heatClass, tableClass;
    string tableId = "table";
    string heatId = "heat";
    string heatTabContent, tableTabConten;

    if (savingHtml && activeTab.ToLower() != "index") {
        heatClass = "active";
        heatTabContent = tabContent;
        tableId += "2";
        heatId += "2";
    } else {
        tableClass = "active";
        tableTabContent = tabContent;
        if (savingHtml) {
            tableId += "1";
            heatId += "1";
        }
    }
}

<div class="summaryTab">
  <ul class="nav nav-tabs" data-tabs="tabs">
    <li class="@heatClass"><a data-toggle="tab" href="#heat">Heat Map</a></li>
    <li class="@tableClass"><a data-toggle="tab" href="#table">Table</a></li>
  </ul>
</div>
<div class="tab-content">
    <div class="tab-pane active" id="@tableId">
        @tableTabContent
    </div>
    <div class="tab-pane" id="@heatId">
        @heatTabContent
    </div>

</div>
  • Note: I have no experience with ASP.Net, so I apologize if the code is not as clean as possible, or has any syntax errors... The gist of the matter is still that if you extract the logic, you get shorter and cleaner code, with much less copy+paste...
share|improve this answer
    
Thanks for your clean and prompt response..cheers!!! –  SivaRajini Mar 6 at 9:53
    
Thank you.it works as expected...accepted –  SivaRajini Mar 6 at 17:19
add comment

Your Answer

 
discard

By posting your answer, you agree to the privacy policy and terms of service.

Not the answer you're looking for? Browse other questions tagged or ask your own question.